HTTPCLIENT-2372 - Normalize HttpHost port comparison to treat implicit default ports as equal #643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ok2c
requested changes
Jun 5, 2025
| return port1 == port2; | ||
| } | ||
|
|
||
| private int getEffectivePort(final HttpHost endpoint) { |
Member
There was a problem hiding this comment.
@arturobernalg Please use SchemePortResolver to resolve the port of a protocol scheme. Please also use the one created by the builder. See HttpClientBuilder
arturobernalg
force-pushed
the
HTTPCLIENT-2372
branch
2 times, most recently
from
9867b91 to
c89277e
Compare
…t default ports as equal
arturobernalg
force-pushed
the
HTTPCLIENT-2372
branch
from
f5b924a to
a5f654e
Compare
ok2c
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that hosts with implicit default ports (e.g., http://example.com) are treated the same as those explicitly specifying port 80 or 443. It introduces a helper method to derive the “effective” port and updates the authority check to use this normalized value. As a result, sensitive headers are no longer stripped when redirecting between example.com and example.com:80 (or :443 for HTTPS).