Skip to content

Conversation

@rschmitt
Copy link
Contributor

@rschmitt rschmitt commented Jun 4, 2025

No description provided.

Copy link
Member

@garydgregory garydgregory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me on Microsoft Windows [Version 10.0.19045.5737].

TY @rschmitt 💯

@ok2c
Copy link
Member

ok2c commented Jun 4, 2025

@rschmitt If the integration tests start failing again I will have to revert this change. Scratch that. GitHub CI tests on Winsdows were disabled for a reason. We can try enabling them again, but as long as the original problem does not reoccur.

@garydgregory
Copy link
Member

This fix solves building on my Windows box. IMO, after we merge this I think we can experiment with Windows builds in the CI again.

@rschmitt rschmitt merged commit c65eb9b into apache:master Jun 4, 2025
10 checks passed
@rschmitt rschmitt deleted the win-fix branch June 4, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants