Add org.apache.hc.client5.http.entity.mime.PathBody #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ok2c
requested changes
Jun 4, 2025
pom.xml
Outdated
| <groupId>commons-io</groupId> | ||
| <artifactId>commons-io</artifactId> | ||
| <version>2.19.0</version> | ||
| <scope>test</scope> |
Member
There was a problem hiding this comment.
@garydgregory I think the scope has no effect here and should be removed
Member
Author
There was a problem hiding this comment.
Thank you for the review @ok2c , fixed, squashed, and pushed.
| * @param name The part name. | ||
| * @param path The source path. | ||
| * @return {@code this} instance. | ||
| * @since 5.5.1 |
Member
Author
There was a problem hiding this comment.
Fixed, squashed, and pushed.
garydgregory
force-pushed
the
master_add_PathBody
branch
from
4829a95 to
b7df6ec
Compare
ok2c
approved these changes
Jun 4, 2025
Member
ok2c
left a comment
ok2c
left a comment
There was a problem hiding this comment.
@garydgregory Looks good now. The next version in master should be 5.6-alpha1. Please rebase your changes and merge
garydgregory
force-pushed
the
master_add_PathBody
branch
from
b7df6ec to
53e96f3
Compare
- Add org.apache.hc.client5.http.entity.mime.MultipartEntityBuilder.addBinaryBody(String, File) - Add org.apache.hc.client5.http.entity.mime.MultipartEntityBuilder.addBinaryBody(String, Path, ContentType, String)
garydgregory
force-pushed
the
master_add_PathBody
branch
from
53e96f3 to
0039b22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.