Skip to content

Fix case of Cookie.HTTP_ONLY_ATTR #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ok2c merged 1 commit into from
Apr 16, 2025
Merged

Fix case of Cookie.HTTP_ONLY_ATTR #631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion httpclient5/src/main/java/org/apache/hc/client5/http/cookie/Cookie.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public interface Cookie {
String MAX_AGE_ATTR = "max-age";
String SECURE_ATTR = "secure";
String EXPIRES_ATTR = "expires";
String HTTP_ONLY_ATTR = "httpOnly";
String HTTP_ONLY_ATTR = "httponly";

/**
* @since 5.0
Expand Down
13 changes: 13 additions & 0 deletions httpclient5/src/test/java/org/apache/hc/client5/http/impl/cookie/TestRFC6265CookieSpec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,19 @@ void testParseCookieWithAttributes3() throws Exception {
Assertions.assertEquals("", cookie.getAttribute("p1"));
}

@Test
void testParseCookieWithHttpOnly() throws Exception {
final RFC6265CookieSpec cookiespec = new RFC6265CookieSpec();

final Header header = new BasicHeader("Set-Cookie", "name = value ; HttpOnly");
final CookieOrigin origin = new CookieOrigin("host", 80, "/path/", true);
final List<Cookie> cookies = cookiespec.parse(header, origin);

Assertions.assertEquals(1, cookies.size());
final Cookie cookie = cookies.get(0);
Assertions.assertTrue(cookie.containsAttribute(Cookie.HTTP_ONLY_ATTR));
}

@Test
void testValidateCookieBasics() throws Exception {
final CommonCookieAttributeHandler h1 = Mockito.mock(CommonCookieAttributeHandler.class);
Expand Down