HTTPCLIENT-2366 - Fix isRepeatable method in RequestEntityProxy to return true before consumption. #630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…turn true before consumption.
ok2c
approved these changes
Apr 4, 2025
Member
|
@arturobernalg Please cherry-pick to |
arturobernalg
added a commit
that referenced
this pull request
Apr 4, 2025
…turn true before consumption. (#630)
Member
Author
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the
isRepeatablemethod inRequestEntityProxy. Previously, if the underlying entity was non-repeatable, the proxy would incorrectly return false even before consumption. The fix ensures that the proxy is always considered repeatable until it is consumed, regardless of the underlying entity's repeatability. Tests have been updated to validate this behavior.