HIVE-29495: [HPLSQL]Setting hive configs in hplsql causing console logs to be lost#6361
Conversation
|
I'm new to HPL, wondering why |
Here all statements present inside 'scriptText' variable will be consider as one statement so only once logging context will be registred for all and at the end the logging context will be unregistered. For HPLSQL the delimiter is /(forward slash) compared to ;(semicolon) for normal SQL statements so for executing HPLSQL statements in beeline we need to pass / at the end so that all statements will be passed to HPLSQL engine once. |
soumyakanti3578
left a comment
There was a problem hiding this comment.
I am approving this as the PR can be merged without addressing the nit (since it was not introduced in this PR).
service/src/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java
Outdated
Show resolved
Hide resolved
179c2f0 to
ab4623a
Compare
|
@mdayakar I see that SonarQube has highlighted "Line is longer than 120 characters" in three places. Could you please fix them too? |
ab4623a to
59e977c
Compare
|



HIVE-29495: [HPLSQL]Setting hive configs in hplsql causing console logs to be lost.
What changes were proposed in this pull request?
When SET hive config is executed, it is executed as a separate HiveCommand which is registrering a new logging context so it is creating a new operation log and after executing SET hive config it is unregistering the logging context which closes the operation log so for all the statements executed after this are not getting logged into operation log so in beeline console nothing is getting showed. Now we are not registering logging context as a part of SET hive config statement, which results in logging into the existing operation log so the logs are coming for all statements executed.
Why are the changes needed?
Without fix, after executing SET hive config there will not be any console logs on the beeline console.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Testcase (testPrintMessageAfterExecuteSetHiveConfig) is added in the TestHplSqlViaBeeLine class
mvn test -Dtest=TestHplSqlViaBeeLine#testPrintMessageAfterExecuteSetHiveConfig -pl itests/hive-unit -Pitests