HBASE-30131 Rewrite TestAsyncMetaRegionLocator#8206
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR rewrites TestAsyncMetaRegionLocator from a JUnit4 Enclosed + RuleChain-based structure into a single JUnit5 @TestTemplate parameterized test, while keeping (and slightly expanding) the OpenTelemetry tracing assertions around meta region location lookup.
Changes:
- Migrates the test to JUnit5 with
@HBaseParameterizedTestTemplateconstructor-parameter injection for running against multipleConnectionRegistryimplementations. - Switches tracing test infrastructure from
OpenTelemetry*Ruleto JUnit5OpenTelemetryExtension. - Consolidates cluster lifecycle management into
@BeforeAll/@AfterAlland adds RpcConnectionRegistry-specific span assertions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
liuxiaocs7
approved these changes
May 8, 2026
Apache9
added a commit
that referenced
this pull request
May 9, 2026
Signed-off-by: Xiao Liu <liuxiaocs@apache.org> (cherry picked from commit fbcd02d)
Apache9
added a commit
to Apache9/hbase
that referenced
this pull request
May 9, 2026
Signed-off-by: Xiao Liu <liuxiaocs@apache.org> (cherry picked from commit fbcd02d)
Apache9
added a commit
that referenced
this pull request
May 11, 2026
(cherry picked from commit fbcd02d) Signed-off-by: Xiao Liu <liuxiaocs@apache.org>
Apache9
added a commit
that referenced
this pull request
May 11, 2026
(cherry picked from commit fbcd02d) Signed-off-by: Xiao Liu <liuxiaocs@apache.org>
Apache9
added a commit
that referenced
this pull request
May 11, 2026
(cherry picked from commit fbcd02d) Signed-off-by: Xiao Liu <liuxiaocs@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.