HBASE-30042 Test AuthUtil.loginClient with existing Kerberos login#8002
Open
jinhyukify wants to merge 1 commit intoapache:masterfrom
Open
HBASE-30042 Test AuthUtil.loginClient with existing Kerberos login#8002jinhyukify wants to merge 1 commit intoapache:masterfrom
jinhyukify wants to merge 1 commit intoapache:masterfrom
Conversation
jinhyukify
commented
Mar 29, 2026
|
|
||
| @Test | ||
| public void testAuthUtilLogin() throws Exception { | ||
| public void testAuthUtilLoginWithExistingLoginUser() throws Exception { |
Contributor
Author
There was a problem hiding this comment.
Let's update this test to only cover the case where a Kerberos user is already logged in.
junegunn
reviewed
Mar 30, 2026
| conf.set(AuthUtil.HBASE_CLIENT_KEYTAB_FILE, clientKeytab); | ||
| conf.set(AuthUtil.HBASE_CLIENT_KERBEROS_PRINCIPAL, clientPrincipal); | ||
| UserGroupInformation.setConfiguration(conf); | ||
| UserGroupInformation.loginUserFromKeytab(clientPrincipal, clientKeytab); |
Member
There was a problem hiding this comment.
Thanks, this issue has been bothering me for a while, and I can confirm this makes the test pass.
However, if we do this, we no longer test if AuthUtil.loginClient actually performs the login for the user. I think we could create a separate user principal, log in as that user, and then test whether AuthUtil.loginClient correctly logs in the original user and returns that user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira https://issues.apache.org/jira/browse/HBASE-30042