HBASE-30008 NPE in CreateNamespaceProcedure and DeleteNamespaceProcedure#7957
Open
dParikesit wants to merge 1 commit intoapache:masterfrom
Open
HBASE-30008 NPE in CreateNamespaceProcedure and DeleteNamespaceProcedure#7957dParikesit wants to merge 1 commit intoapache:masterfrom
dParikesit wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: HBASE-30008
Currently, CreateNamespaceProcedure:setNamespaceQuota and DeleteNamespaceProcedure:removeNamespaceQuota gets MasterQuotaManager by using
env.getMasterServices().getMasterQuotaManager().It is possible that HMaster marks itself initialized before it creates and stores quotaManager, which can cause NPE. Oher procedures prevent this issue by using
ProcedureSyncWait.getMasterQuotaManager(env)which will wait for the quotaManager to be ready.I’ve provided a fix to use ProcedureSyncWait.getMasterQuotaManager instead of directly getting it from the masterServices.