HBASE-28123 TableRequests metrics broken after altering table#7855
Open
liuxiaocs7 wants to merge 1 commit intoapache:masterfrom
Open
HBASE-28123 TableRequests metrics broken after altering table#7855liuxiaocs7 wants to merge 1 commit intoapache:masterfrom
liuxiaocs7 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
liuxiaocs7
commented
Mar 5, 2026
liuxiaocs7
commented
- see: HBASE-28123
liuxiaocs7
commented
Mar 5, 2026
Comment on lines
65
to
+76
| private class MetricsSourceAdapter implements MetricsSource { | ||
| private final MetricRegistry registry; | ||
| private final MetricRegistryInfo info; | ||
|
|
||
| MetricsSourceAdapter(MetricRegistry registry) { | ||
| this.registry = registry; | ||
| MetricsSourceAdapter(MetricRegistryInfo info) { | ||
| this.info = info; | ||
| } | ||
|
|
||
| @Override | ||
| public void getMetrics(MetricsCollector collector, boolean all) { | ||
| metricsAdapter.snapshotAllMetrics(registry, collector); | ||
| Optional<MetricRegistry> registryOpt = MetricRegistries.global().get(info); | ||
| registryOpt | ||
| .ifPresent(metricRegistry -> metricsAdapter.snapshotAllMetrics(metricRegistry, collector)); |
Contributor
Author
There was a problem hiding this comment.
this is the fix, we should always use the newest metricRegistry here
Contributor
Author
|
Hi, @Apache9, what do you think of this change for this bug, more details see HBASE-28123, Thanks! |
Contributor
Author
|
Now the CI pass all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.