refactored TimeDuration, added AgoDate, added TimeAgoFromData;#1828
Closed
h1alexbel wants to merge 1 commit intoapache:masterfrom
Closed
refactored TimeDuration, added AgoDate, added TimeAgoFromData;#1828h1alexbel wants to merge 1 commit intoapache:masterfrom
h1alexbel wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
Hi Aliaksei Bialiauski. While there is nothing wrong with your refactorings, we'd typically want some discussion in a forum or mailing list so we could discuss merits of this versus other possible changes we could make. Please reopen and start a discussion if you feel there is a real improvement in functoinality that Groovy needs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.