Skip to content

[flink] unify the behavior of different startup mode for lake table#2572

Open
luoyuxia wants to merge 1 commit intoapache:mainfrom
luoyuxia:unify-lake-table-scan-mode-behevior
Open

[flink] unify the behavior of different startup mode for lake table#2572
luoyuxia wants to merge 1 commit intoapache:mainfrom
luoyuxia:unify-lake-table-scan-mode-behevior

Conversation

@luoyuxia
Copy link
Contributor

@luoyuxia luoyuxia commented Feb 4, 2026

Purpose

Linked issue: close #xxx

Brief change log

Tests

API and Format

Documentation

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR unifies the behavior of different startup modes for lake tables by removing special timestamp filtering logic for lake sources. The changes align the implementation with documented behavior where non-FULL startup modes (EARLIEST, LATEST, TIMESTAMP) read only from log sources, not from lake sources.

Changes:

  • Removed test file FlinkUnionReadFromTimestampITCase.java that tested timestamp-based union reads from lake and log
  • Simplified startup mode logic in FlinkTableSource.java by removing pushTimeStampFilterToLakeSource method
  • Changed TIMESTAMP and EARLIEST modes to not use lake source (only FULL mode now uses lake source when available)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
FlinkUnionReadFromTimestampITCase.java Deleted test file that tested union reads with timestamp filtering on lake sources
FlinkTableSource.java Simplified startup mode logic by removing timestamp filter pushdown to lake sources and limiting lake source usage to FULL mode only

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@luoyuxia luoyuxia force-pushed the unify-lake-table-scan-mode-behevior branch from 123b8d3 to 50f34e3 Compare February 5, 2026 01:46
@beryllw
Copy link
Contributor

beryllw commented Feb 5, 2026

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants