[flink] unify the behavior of different startup mode for lake table#2572
Open
luoyuxia wants to merge 1 commit intoapache:mainfrom
Open
[flink] unify the behavior of different startup mode for lake table#2572luoyuxia wants to merge 1 commit intoapache:mainfrom
luoyuxia wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR unifies the behavior of different startup modes for lake tables by removing special timestamp filtering logic for lake sources. The changes align the implementation with documented behavior where non-FULL startup modes (EARLIEST, LATEST, TIMESTAMP) read only from log sources, not from lake sources.
Changes:
- Removed test file
FlinkUnionReadFromTimestampITCase.javathat tested timestamp-based union reads from lake and log - Simplified startup mode logic in
FlinkTableSource.javaby removingpushTimeStampFilterToLakeSourcemethod - Changed TIMESTAMP and EARLIEST modes to not use lake source (only FULL mode now uses lake source when available)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| FlinkUnionReadFromTimestampITCase.java | Deleted test file that tested union reads with timestamp filtering on lake sources |
| FlinkTableSource.java | Simplified startup mode logic by removing timestamp filter pushdown to lake sources and limiting lake source usage to FULL mode only |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...s-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/source/FlinkTableSource.java
Show resolved
Hide resolved
123b8d3 to
50f34e3
Compare
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
Brief change log
Tests
API and Format
Documentation