[FLINK-38023][formats] Fix GenericRecord Avro state migration#28161
Open
avi-sanwal wants to merge 4 commits into
Open
[FLINK-38023][formats] Fix GenericRecord Avro state migration#28161avi-sanwal wants to merge 4 commits into
avi-sanwal wants to merge 4 commits into
Conversation
Resolve GenericRecord values with an older record schema to the serializer runtime schema before writing them during state migration. Generated-by: OpenAI Codex GPT-5
Collaborator
Align GenericRecord restore behavior with SpecificRecord by constructing the restored reader with previous and current schemas instead of rewriting records at serialize time. Generated-by: OpenAI Codex GPT-5
Handle the nullable previous schema inside the GenericRecord factory helper instead of passing Optional as a parameter. Generated-by: OpenAI Codex GPT-5
Generated-by: OpenAI Codex (GPT-5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request fixes GenericRecord Avro state migration when compatible schema evolution changes the record shape, for example by adding a field with a default.
During migration, Flink can deserialize old state bytes with the restored previous serializer. For GenericRecord that value can still carry the old Avro schema, while the new serializer must write bytes using the new schema. Writing the old-shaped GenericRecord directly with the new GenericDatumWriter can fail or address fields by the wrong index.
Brief change log
Verifying this change
This change added tests and can be verified as follows:
AvroSerializerSnapshotTest#migratedGenericRecordShouldBeSerializedWithNewSchema.AvroSerializerSnapshotTest#migratedGenericRecordShouldBeSerializedWithNewSchemaWhenFieldIsInsertedInMiddle../mvnw -pl flink-formats/flink-avro spotless:apply -Dspotless.check.skip=false../mvnw -pl flink-formats/flink-avro -am -Dtest=AvroSerializerSnapshotTest -DfailIfNoTests=false -Dsurefire.failIfNoSpecifiedTests=false -Dcheckstyle.skip -Drat.skip -Dspotless.check.skip test.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: OpenAI Codex GPT-5