[fix][improvement] Propagate nullability of the column alongside with the AlterColumnTypeEvent#4372
Open
CatOrLeader wants to merge 5 commits intoapache:masterfrom
Open
[fix][improvement] Propagate nullability of the column alongside with the AlterColumnTypeEvent#4372CatOrLeader wants to merge 5 commits intoapache:masterfrom
CatOrLeader wants to merge 5 commits intoapache:masterfrom
Conversation
added 3 commits
April 9, 2026 22:39
Alongside with the type change, it is necessary to change nullability of the column
Alongside with the type change, it is necessary to change nullability of the column
Alongside with the type change, it is necessary to change nullability of the column
added 2 commits
April 9, 2026 22:59
Alongside with the type change, it is necessary to change nullability of the column
Alongside with the type change, it is necessary to change nullability of the column
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The situation I am describing is as follows:
When a DropColumnEvent occurs, the lenient transformation changes the event type to AlterColumnTypeEvent, making the column nullable. However, in the previous code, there were no changes to the nullability. Instead, only the column type was changed.
Now, an additional check is made for column nullability, and the changes are correctly propagated.