[ci] Fix docker environment related test failure#4275
[ci] Fix docker environment related test failure#4275lvyanquan merged 3 commits intoapache:masterfrom
Conversation
5a914f6 to
ae37570
Compare
|
The testcontainers v1.21.4 seems to contain the fix too, if you prefer to avoid the workaround |
Great! Thanks for reminding :) |
+1, upgrade testcontainers to |
7111211 to
3527f54
Compare
3527f54 to
c2f5463
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes Docker environment-related test failures by upgrading testcontainers-java and adjusting CI infrastructure to work around OpenJDK issues.
Changes:
- Upgraded testcontainers-java from 1.18.3 to 1.21.4 to include patch for issue #11212
- Replaced testcontainers shaded Guava imports with Flink's shaded Guava (guava31) in test files to avoid dependency conflicts
- Added testcontainers exclusions to all modules using flink-test-utils or flink-connector-test-utils dependencies
- Pinned GitHub Actions Ubuntu runner to 22.04 as workaround for JDK-8348566 and JDK-8349988
Reviewed changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Bumped testcontainers.version property from 1.18.3 to 1.21.4 |
| flink-cdc-runtime/src/test/java/org/apache/flink/cdc/runtime/operators/transform/PreTransformOperatorTest.java | Changed ImmutableMap import from testcontainers shaded to flink shaded guava31 |
| flink-cdc-runtime/src/test/java/org/apache/flink/cdc/runtime/operators/transform/PostTransformOperatorTest.java | Changed ImmutableMap import from testcontainers shaded to flink shaded guava31 |
| flink-cdc-runtime/src/test/java/org/apache/flink/cdc/runtime/operators/schema/common/SchemaManagerTest.java | Changed ImmutableMap import from testcontainers shaded to flink shaded guava31 |
| flink-cdc-runtime/pom.xml | Added testcontainers exclusion for flink-test-utils-junit dependency |
| flink-cdc-pipeline-model/pom.xml | Added testcontainers exclusion for flink-test-utils-junit dependency |
| flink-cdc-connect/flink-cdc-source-connectors/flink-connector-vitess-cdc/pom.xml | Added testcontainers exclusion for flink-test-utils dependency |
| flink-cdc-connect/flink-cdc-source-connectors/flink-connector-tidb-cdc/pom.xml | Added testcontainers exclusions for flink-test-utils and flink-connector-test-utils dependencies |
| flink-cdc-connect/flink-cdc-source-connectors/flink-connector-test-util/pom.xml | Added testcontainers exclusion for flink-test-utils dependency |
| flink-cdc-connect/flink-cdc-source-connectors/flink-connector-sqlserver-cdc/pom.xml | Added testcontainers exclusions for flink-test-utils and flink-connector-test-utils dependencies |
| flink-cdc-connect/flink-cdc-source-connectors/flink-connector-postgres-cdc/pom.xml | Added testcontainers exclusions for flink-test-utils and flink-connector-test-utils dependencies |
| flink-cdc-connect/flink-cdc-source-connectors/flink-connector-oracle-cdc/pom.xml | Added testcontainers exclusions for flink-test-utils and flink-connector-test-utils dependencies |
| flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/pom.xml | Added testcontainers exclusions for flink-test-utils and flink-connector-test-utils dependencies |
| flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mongodb-cdc/pom.xml | Added testcontainers exclusions for flink-test-utils and flink-connector-test-utils dependencies |
| flink-cdc-connect/flink-cdc-source-connectors/flink-connector-debezium/pom.xml | Added testcontainers exclusion for flink-test-utils dependency |
| flink-cdc-connect/flink-cdc-source-connectors/flink-connector-db2-cdc/pom.xml | Added testcontainers exclusions for flink-test-utils-junit and flink-test-utils dependencies |
| flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/pom.xml | Added testcontainers exclusions for flink-test-utils and flink-connector-test-utils dependencies |
| flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-starrocks/pom.xml | Added testcontainers exclusions for flink-test-utils-junit and flink-test-utils dependencies |
| flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-postgres/pom.xml | Added testcontainers exclusions for flink-test-utils and flink-connector-test-utils dependencies |
| flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-oracle/pom.xml | Added testcontainers exclusions for flink-test-utils and flink-connector-test-utils dependencies |
| flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-oceanbase/pom.xml | Added testcontainers exclusion for flink-test-utils dependency |
| flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/pom.xml | Added testcontainers exclusions for flink-test-utils and flink-connector-test-utils dependencies |
| flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-kafka/pom.xml | Added testcontainers exclusion for flink-test-utils dependency |
| flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-iceberg/pom.xml | Added testcontainers exclusions for flink-test-utils and flink-test-utils-junit dependencies |
| flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-fluss/pom.xml | Added testcontainers exclusion for flink-test-utils dependency |
| flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-elasticsearch/pom.xml | Added testcontainers exclusions for flink-test-utils and flink-connector-test-utils dependencies |
| flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-doris/pom.xml | Added testcontainers exclusions for flink-test-utils-junit and flink-test-utils dependencies |
| flink-cdc-composer/src/test/java/org/apache/flink/cdc/composer/flink/FlinkPipelineComposerLenientITCase.java | Changed ImmutableMap import from testcontainers shaded to flink shaded guava31 |
| flink-cdc-composer/src/test/java/org/apache/flink/cdc/composer/flink/FlinkPipelineComposerITCase.java | Changed ImmutableMap import from testcontainers shaded to flink shaded guava31 |
| flink-cdc-composer/pom.xml | Added testcontainers exclusion for flink-test-utils dependency |
| .github/workflows/flink_cdc_base.yml | Pinned Ubuntu runner to version 22.04 as workaround for JDK-8348566 and JDK-8349988 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
It seems the test case |
Fixed. It seems there's a redundant # flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mongodb-cdc/src/test/java/org/apache/flink/cdc/connectors/mongodb/utils/MongoDBContainer.java
throw new IllegalStateException(
"Execute mongo command failed " + execResult.getStderr());
}
- this.waitingFor(Wait.forLogMessage("Flink test user created.\\s", 1));
} catch (Exception e) {
throw new RuntimeException(e);
}As |
This PR: