Skip to content

[FLINK-37485][starrocks] Add support for TIME type#4253

Open
Hisoka-X wants to merge 4 commits intoapache:masterfrom
Hisoka-X:starrocks-time
Open

[FLINK-37485][starrocks] Add support for TIME type#4253
Hisoka-X wants to merge 4 commits intoapache:masterfrom
Hisoka-X:starrocks-time

Conversation

@Hisoka-X
Copy link
Member

@Hisoka-X Hisoka-X commented Feb 1, 2026

This close https://issues.apache.org/jira/browse/FLINK-37485

This pull request adds comprehensive support for the SQL TIME type (with and without precision) in the StarRocks pipeline connector, including serialization, schema evolution, and documentation updates. It also corrects documentation for timeout parameter types and value ranges, and introduces a new configuration for histogram metric window size.

@github-actions github-actions bot added docs Improvements or additions to documentation starrocks-pipeline-connector labels Feb 1, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds end-to-end support for the CDC TIME type in the StarRocks pipeline connector by mapping it to a compatible StarRocks type and validating behavior through unit/integration tests, alongside related documentation and test-stability improvements.

Changes:

  • Add TIME schema + serialization handling for StarRocks (mapped to VARCHAR).
  • Extend StarRocks connector tests to cover TIME creation, evolution, and serialization.
  • Update StarRocks connector docs (option types/ranges, new metric option, TIME mapping) and improve Fluss IT test readiness.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-starrocks/src/main/java/org/apache/flink/cdc/connectors/starrocks/sink/StarRocksUtils.java Implements TIME value formatting and maps TimeType to StarRocks VARCHAR with computed length.
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-starrocks/src/test/java/org/apache/flink/cdc/connectors/starrocks/sink/StarRocksMetadataApplierTest.java Adds unit tests for TIME column mapping and schema evolution.
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-starrocks/src/test/java/org/apache/flink/cdc/connectors/starrocks/sink/StarRocksMetadataApplierITCase.java Enables TIME in StarRocks datatype IT coverage and validates mapped schema output.
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-starrocks/src/test/java/org/apache/flink/cdc/connectors/starrocks/sink/EventRecordSerializationSchemaTest.java Adds serialization tests for TIME values (precision, evolution, nulls, boundaries).
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-fluss/src/test/java/org/apache/flink/cdc/connectors/fluss/FlussPipelineITCase.java Adds a cluster readiness wait to reduce flakiness in Fluss pipeline ITs.
docs/content/docs/connectors/pipeline-connectors/starrocks.md Updates option types, adds metric option, and documents TIME-to-VARCHAR mapping.
docs/content.zh/docs/connectors/pipeline-connectors/starrocks.md Same as above for Chinese docs, including corrected timeout range.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation starrocks-pipeline-connector

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants