Skip to content

FINERACT-2633: Rework datasource connection handling#5948

Merged
adamsaghy merged 1 commit into
apache:developfrom
openMF:FINERACT-2421/rework-datasource-connection-handling
Jun 8, 2026
Merged

FINERACT-2633: Rework datasource connection handling#5948
adamsaghy merged 1 commit into
apache:developfrom
openMF:FINERACT-2421/rework-datasource-connection-handling

Conversation

@adamsaghy

@adamsaghy adamsaghy commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Description

Connection pool exhaustion issues were noticed.

Following optimizations were done:

  • Close more aggressively datasource connections (where applicable)
  • Reworked COB locking to rely on JDBC Repositories solely (no mixed JPA + JDBC connections around locking)
  • Separate 3 kind of transaction managers:
    • JPA transaction manager (default)
    • JDBC transaction manager (used by new command framework)
    • Batch job JDBC transaction manager (used by Spring Batch for JDBC repository operations)
  • Connection pool exhaustion diagnostics added

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@adamsaghy adamsaghy force-pushed the FINERACT-2421/rework-datasource-connection-handling branch 6 times, most recently from df74397 to 856ddc8 Compare June 6, 2026 21:04
@adamsaghy adamsaghy marked this pull request as ready for review June 8, 2026 09:21
@adamsaghy adamsaghy force-pushed the FINERACT-2421/rework-datasource-connection-handling branch from 856ddc8 to e477ced Compare June 8, 2026 09:24
@adamsaghy adamsaghy changed the title FINERACT-2421: Rework datasource connection handling FINERACT-2633: Rework datasource connection handling Jun 8, 2026
@adamsaghy adamsaghy force-pushed the FINERACT-2421/rework-datasource-connection-handling branch from e477ced to ef1f878 Compare June 8, 2026 13:51
@budaidev

budaidev commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

LGTM

@adamsaghy adamsaghy force-pushed the FINERACT-2421/rework-datasource-connection-handling branch from ef1f878 to 4c3db81 Compare June 8, 2026 14:54

@Cocoa-Puffs Cocoa-Puffs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adamsaghy adamsaghy force-pushed the FINERACT-2421/rework-datasource-connection-handling branch from 4c3db81 to e942569 Compare June 8, 2026 18:19
FINERACT-2633: Use JDBC Repository for account locking
@adamsaghy adamsaghy force-pushed the FINERACT-2421/rework-datasource-connection-handling branch from e942569 to 6bfb881 Compare June 8, 2026 18:34
@adamsaghy adamsaghy merged commit 1888a3d into apache:develop Jun 8, 2026
177 of 178 checks passed
@adamsaghy adamsaghy deleted the FINERACT-2421/rework-datasource-connection-handling branch June 8, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants