Skip to content

FINERACT-2519: Refactor CreditBureauIntegration tests to use fineract-client#5575

Open
DeathGun44 wants to merge 1 commit intoapache:developfrom
DeathGun44:FINERACT-2519/credit-bureau-integration-client-migration
Open

FINERACT-2519: Refactor CreditBureauIntegration tests to use fineract-client#5575
DeathGun44 wants to merge 1 commit intoapache:developfrom
DeathGun44:FINERACT-2519/credit-bureau-integration-client-migration

Conversation

@DeathGun44
Copy link
Contributor

Description

CreditBureauIntegrationApiResource was missing @Tag, so the client was never generated. Added it, registered the new API in FineractClient, and migrated CreditBureauIntegrationHelper + CreditBureauTest off REST-assured. Also removed dead uploadCreditReport code. Follows up on FINERACT-2513.

Checklist

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant