FINERACT-2518: Fix to Savings account tests date timezone

[edk12564]

JIRA: FINERACT-2518

Problem

After investigating, it turns out PRs have been failing due to a mismatch between the CI/CD date locality (Asia/Kolkata), which is the default tenant timezone, and date locality used in SavingsAccountsExternalIdTests (UTC). At certain times of the day, we get a date mismatch, which corresponds to the errors we have been getting.

The time of the CI/CD commit failures was around 1-2pm US Central. Notably, this is after 12am in Asia/Kolkata, resulting in a future date.

Failed CI/CD tests are similar between commits. We get failed data validation due to: ...cannot.be.before.client.activation.date. We can also see that in submitSavingsAccountApplication(), we use a date of 2026-03-03, but the submittedOnDate we pass in is 02 March 2026. Subsequent errors seem to be cascaded from this one, since these Savings tests rely on submitSavingsAccountApplication() due to their @order.

Below is a picture showing these errors from github.

Changes

Changed the hardcoded UTC to getLocalDateOfTenant() which defaults to Asia/Kolkata. This matches the default tenant timezone used in CI/CD.

Results

Tests pass with changes:

Might need further testing during the mismatch window (eg. 1pm US Central).

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• Write the commit message as per our guidelines
• Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
• Create/update unit or integration tests for verifying the changes made.
• Follow our coding conventions.
• Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
• This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.