Skip to content

FINERACT-2516: Upgrade MariaDB support to version 12#5566

Open
airajena wants to merge 1 commit intoapache:developfrom
airajena:FINERACT-2516/upgrade-to-mariadb-version-12
Open

FINERACT-2516: Upgrade MariaDB support to version 12#5566
airajena wants to merge 1 commit intoapache:developfrom
airajena:FINERACT-2516/upgrade-to-mariadb-version-12

Conversation

@airajena
Copy link
Contributor

@airajena airajena commented Mar 1, 2026

FINERACT-2516

Summary

This PR upgrades MariaDB support from 11.x to 12.x across runtime, development, and test container references, and updates the MariaDB JDBC driver version.

Scope

  • No functional business-logic changes
  • No API contract changes
  • No schema/Liquibase changes
  • Version/reference upgrade only

Risk

Low.
Changes are limited to version references for MariaDB image/driver and associated docs/test setup.

@meonkeys
Copy link
Contributor

meonkeys commented Mar 1, 2026

I can review this tomorrow.

I did a mariadb version bump a while ago, see b053c90

@meonkeys
Copy link
Contributor

meonkeys commented Mar 1, 2026

Oh never mind, looks like @IOhacker is re-running the ci jobs... are you reviewing, @IOhacker ? If not, let me know, I'm happy to help.

@meonkeys
Copy link
Contributor

meonkeys commented Mar 1, 2026

I see MariaDB >= 11.5.2 in several places (try git grep '11\.5\.2'). I think just make all those 12.2 as well.

Copy link
Contributor

@meonkeys meonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the diff looks fine to me except:

  1. It looks like CI is still failing so far.
  2. I think we should change everywhere 11.5.2 shows up in the docs to 12.2.

I also haven't run any tests locally with mariadb 12.2 yet. I'll do that now.

@airajena , are you able to identify, repro, and fix the failing tests?

@IOhacker
Copy link
Contributor

IOhacker commented Mar 2, 2026

@meonkeys always happy to have a hand during the review.

@IOhacker
Copy link
Contributor

IOhacker commented Mar 2, 2026

@airajena please do a rebase

@airajena
Copy link
Contributor Author

airajena commented Mar 2, 2026

I see MariaDB >= 11.5.2 in several places (try git grep '11\.5\.2'). I think just make all those 12.2 as well.

Yes working on it

@airajena airajena force-pushed the FINERACT-2516/upgrade-to-mariadb-version-12 branch from 91ed346 to 471bc24 Compare March 2, 2026 08:11
@airajena
Copy link
Contributor Author

airajena commented Mar 2, 2026

the diff looks fine to me except:

  1. It looks like CI is still failing so far.
  2. I think we should change everywhere 11.5.2 shows up in the docs to 12.2.

I also haven't run any tests locally with mariadb 12.2 yet. I'll do that now.

@airajena , are you able to identify, repro, and fix the failing tests?

I checked the failing ci checks, they are not related to version change, if it was then it should show concrete SQL/driver error.

@airajena airajena force-pushed the FINERACT-2516/upgrade-to-mariadb-version-12 branch from 471bc24 to 07a9ee4 Compare March 2, 2026 18:26
@meonkeys
Copy link
Contributor

meonkeys commented Mar 2, 2026

@airajena wrote:

I checked the failing ci checks, they are not related to version change, if it was then it should show concrete SQL/driver error.

Thanks for checking. I understand and agree.

We still need a passing build before merging.

I skimmed the build logs, but I don't understand the test failures and there are many. I'll try re-running all the failed tests.

Otherwise this PR looks good to me.

Did you figure out what was mucking with line endings for the .adoc files?

@meonkeys meonkeys dismissed their stale review March 2, 2026 18:45

was addressed

@airajena
Copy link
Contributor Author

airajena commented Mar 2, 2026

@airajena wrote:

I checked the failing ci checks, they are not related to version change, if it was then it should show concrete SQL/driver error.

Thanks for checking. I understand and agree.

We still need a passing build before merging.

Otherwise this PR looks good to me.

Did you figure out what was mucking with line endings for the .adoc files?

Yes, repo has no .gitattributes rule enforcing .adoc line endings. git check-attr for those .adoc files returns no EOL attributes. Those files are expected as LF (git ls-files --eol shows i/lf). I have windows, so if any Windows tool saves with CRLF (for example a full-file rewrite API/editor default), Git sees the whole file as changed. That’s exactly the churn pattern we hit.

@meonkeys
Copy link
Contributor

meonkeys commented Mar 2, 2026

@airajena integration tests are still failing and I don't know why. Can you learn anything else from the logs? Can you repro locally?

I'd say try rebasing onto the tip of develop, but maybe that's a bad idea: Looks like the build on develop has been broken for a dozen commits now. I'll ping @adamsaghy in chat (#fineract on Mifos Slack).

@nidhiii128
Copy link
Contributor

hii @airajena just a suggestion try running grep -r "mariadb" . , i found more files where changes are needed like

kubernetes/fineractmysql-deployment.yml
docker-compose-development.yml
fineract-doc/src/docs/en/chapters/testing/integration.adoc
fineract-doc/src/docs/en/chapters/testing/cucumber.adoc
.github/workflows/build-docker.yml

i hope it helps you

@airajena
Copy link
Contributor Author

airajena commented Mar 3, 2026

hii @airajena just a suggestion try running grep -r "mariadb" . , i found more files where changes are needed like

kubernetes/fineractmysql-deployment.yml docker-compose-development.yml fineract-doc/src/docs/en/chapters/testing/integration.adoc fineract-doc/src/docs/en/chapters/testing/cucumber.adoc .github/workflows/build-docker.yml

i hope it helps you

@nidhiii128 Thanks for sharing
In my PR
I have these file changes already
kubernetes/fineractmysql-deployment.yml
fineract-doc/src/docs/en/chapters/testing/integration.adoc
fineract-doc/src/docs/en/chapters/testing/cucumber.adoc

Regarding
.github/workflows/build-docker.yml
docker-compose-development.yml
In these two files, I am not seeing any version mentioned. I might be missing something, please let me know if I have missed anythin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants