FINERACT-2516: Upgrade MariaDB support to version 12#5566
FINERACT-2516: Upgrade MariaDB support to version 12#5566airajena wants to merge 1 commit intoapache:developfrom
Conversation
|
I can review this tomorrow. I did a mariadb version bump a while ago, see b053c90 |
|
I see |
There was a problem hiding this comment.
the diff looks fine to me except:
- It looks like CI is still failing so far.
- I think we should change everywhere
11.5.2shows up in the docs to12.2.
I also haven't run any tests locally with mariadb 12.2 yet. I'll do that now.
@airajena , are you able to identify, repro, and fix the failing tests?
|
@meonkeys always happy to have a hand during the review. |
|
@airajena please do a rebase |
Yes working on it |
91ed346 to
471bc24
Compare
I checked the failing ci checks, they are not related to version change, if it was then it should show concrete SQL/driver error. |
471bc24 to
07a9ee4
Compare
|
@airajena wrote:
Thanks for checking. I understand and agree. We still need a passing build before merging. I skimmed the build logs, but I don't understand the test failures and there are many. I'll try re-running all the failed tests. Otherwise this PR looks good to me. Did you figure out what was mucking with line endings for the |
Yes, repo has no .gitattributes rule enforcing .adoc line endings. git check-attr for those .adoc files returns no EOL attributes. Those files are expected as LF (git ls-files --eol shows i/lf). I have windows, so if any Windows tool saves with CRLF (for example a full-file rewrite API/editor default), Git sees the whole file as changed. That’s exactly the churn pattern we hit. |
|
@airajena integration tests are still failing and I don't know why. Can you learn anything else from the logs? Can you repro locally? I'd say try rebasing onto the tip of |
|
hii @airajena just a suggestion try running grep -r "mariadb" . , i found more files where changes are needed like kubernetes/fineractmysql-deployment.yml i hope it helps you |
@nidhiii128 Thanks for sharing Regarding |
FINERACT-2516
Summary
This PR upgrades MariaDB support from 11.x to 12.x across runtime, development, and test container references, and updates the MariaDB JDBC driver version.
Scope
Risk
Low.
Changes are limited to version references for MariaDB image/driver and associated docs/test setup.