FINERACT-2512: Clamp invalid fee month/day on read to avoid 500 (e.g. Feb 30 → Feb 29)#5559
Open
oluexpert99 wants to merge 2 commits intoapache:developfrom
Open
FINERACT-2512: Clamp invalid fee month/day on read to avoid 500 (e.g. Feb 30 → Feb 29)#5559oluexpert99 wants to merge 2 commits intoapache:developfrom
oluexpert99 wants to merge 2 commits intoapache:developfrom
Conversation
Contributor
|
@oluexpert99 squash and commit |
Contributor
|
@oluexpert99 sign your commit |
oluexpert99
force-pushed
the
bugfix/FINERACT-2512
branch
2 times, most recently
from
c75cd8d to
a59f40f
Compare
Contributor
Author
@IOhacker , done |
oluexpert99
force-pushed
the
bugfix/FINERACT-2512
branch
from
a59f40f to
9a02537
Compare
…ns in savings product templates
oluexpert99
force-pushed
the
bugfix/FINERACT-2512
branch
from
9a02537 to
b85a95f
Compare
Contributor
|
@oluexpert99 could you please review the log output. |
adamsaghy
reviewed
Mar 2, 2026
Comment on lines
+496
to
+499
| public static MonthDay safeMonthDay(int month, int day) { | ||
| int maxDay = YearMonth.of(2024, month).lengthOfMonth(); | ||
| int safeDay = Math.min(day, maxDay); | ||
| return MonthDay.of(month, safeDay); |
Contributor
There was a problem hiding this comment.
Having Feb 29 is just as bad as having feb 30 or feb 31... leap years has only feb 29 only... so from 4 years 3 has feb 28 only, i dont see any improvement here...
Am I missing something here?
adamsaghy
requested changes
Mar 2, 2026
Contributor
adamsaghy
left a comment
adamsaghy
left a comment
There was a problem hiding this comment.
Please see my concerns!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fee_on_month/fee_on_day and recurrence month/day from DB
savings product with template, standing instructions, or savings account charges
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.