Skip to content

Conversation

@adamsaghy
Copy link
Contributor

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@adamsaghy adamsaghy force-pushed the FINERACT-2421/verify-liquibase-compability branch 2 times, most recently from b76e6f1 to 2cbffd3 Compare January 11, 2026 22:31

steps:
- name: Checkout the base branch (`develop`)
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems Ok just asking if i run this check in forked branch on push event which develop branch will it checkout? That forks develop eg. forkedRepo/develop or only apache/develop?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it takes the origin which would be "apache", but i can double check.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/Aman-Mittal/fineract/actions/runs/20916627097/job/60091598962?pr=4

Im running this workflow in my forked repo to crosscheck, will confirm you with results. what it is doing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just crosschecked

When we create PR- it checks the forked branch repo, based on to where PR is trying to merge when i raised the pr against my forked develop it checked out to my forked develop branch

https://github.com/Aman-Mittal/fineract/actions/runs/20916627097/job/60091598962?pr=4

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ok to merge. Behaviour is based on where the GA is ran. For anyone who wants to tests this new GA check i think we should add this on md file. where forked develop must be synced with upstream develop.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think it would be safer to use the PR base repo and ref here... let me rework.

@adamsaghy adamsaghy force-pushed the FINERACT-2421/verify-liquibase-compability branch 4 times, most recently from 4142ace to 103e220 Compare January 12, 2026 12:01
@adamsaghy adamsaghy force-pushed the FINERACT-2421/verify-liquibase-compability branch from 103e220 to 8e0d261 Compare January 12, 2026 12:26
@adamsaghy adamsaghy merged commit a210834 into apache:develop Jan 12, 2026
35 checks passed
@meonkeys
Copy link
Contributor

see also: #5264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants