-
Notifications
You must be signed in to change notification settings - Fork 2.2k
FINERACT-2421: Add Verify Liquibase Backward Compatibility check
#5313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FINERACT-2421: Add Verify Liquibase Backward Compatibility check
#5313
Conversation
b76e6f1 to
2cbffd3
Compare
|
|
||
| steps: | ||
| - name: Checkout the base branch (`develop`) | ||
| uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems Ok just asking if i run this check in forked branch on push event which develop branch will it checkout? That forks develop eg. forkedRepo/develop or only apache/develop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it takes the origin which would be "apache", but i can double check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/Aman-Mittal/fineract/actions/runs/20916627097/job/60091598962?pr=4
Im running this workflow in my forked repo to crosscheck, will confirm you with results. what it is doing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just crosschecked
- /usr/bin/git -c protocol.version=2 fetch --prune --no-recurse-submodules origin +refs/heads/:refs/remotes/origin/ +refs/tags/:refs/tags/
From https://github.com/Aman-Mittal/fineract- [new branch] FINERACT-2326/Refactor-some-logical-codes -> origin/FINERACT-2326/Refactor-some-logical-codes
- [new branch] FINERACT-2326/depricated-code-and-optimizations -> origin/FINERACT-2326/depricated-code-and-optimizations
- [new branch] FINERACT-2346/Refactor-maintainability-issue -> origin/FINERACT-2346/Refactor-maintainability-issue
- [new branch] FINERACT-2346/sonarqube-fixes -> origin/FINERACT-2346/sonarqube-fixes
- [new branch] FINERACT-2402/kafka-docker-update -> origin/FINERACT-2402/kafka-docker-update
- [new branch] FINERACT-2402/kafka-server-env-changes -> origin/FINERACT-2402/kafka-server-env-changes
- [new branch] FINERACT-2421/antMatcher-deprecation -> origin/FINERACT-2421/antMatcher-deprecation
- [new branch] FINERACT-2421/maintainabilility-refractor-phase-3 -> origin/FINERACT-2421/maintainabilility-refractor-phase-3
- [new branch] FINERACT-2421/maintainability-refractor-phase-4 -> origin/FINERACT-2421/maintainability-refractor-phase-4
- [new branch] FINERACT-2421/maintainability-refractor-phase-5 -> origin/FINERACT-2421/maintainability-refractor-phase-5
- [new branch] FINERACT-2421/verify-liquibase-compability -> origin/FINERACT-2421/verify-liquibase-compability
When we create PR- it checks the forked branch repo, based on to where PR is trying to merge when i raised the pr against my forked develop it checked out to my forked develop branch
https://github.com/Aman-Mittal/fineract/actions/runs/20916627097/job/60091598962?pr=4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ok to merge. Behaviour is based on where the GA is ran. For anyone who wants to tests this new GA check i think we should add this on md file. where forked develop must be synced with upstream develop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I think it would be safer to use the PR base repo and ref here... let me rework.
4142ace to
103e220
Compare
103e220 to
8e0d261
Compare
|
see also: #5264 |
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.