-
Notifications
You must be signed in to change notification settings - Fork 2.2k
FINERACT-2430: Fix typo: rename acount to `account
#5312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FINERACT-2430: Fix typo: rename acount to `account
#5312
Conversation
Aman-Mittal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small Change - in comment code
|
@Aman-Mittal yes a very tiny change , I too was suprised at first. |
adamsaghy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you run a search for the word of acount and fix all occurrences?
I believe there is a org.apache.fineract.portfolio.tax.domain.TaxComponent#getDebitAcount which seems incorrect.
|
Yeah sure please create a ticket for that and assign that to me . |
|
@Kengne-yvana I dont want to create a new ticket for this, you can fix part of this PR. Lets just rename the PR and commit message to: |
|
@adamsaghy Ok , I understand. |
acount to `account
|
@adamsaghy From my search i noticed |
Please pull the latest |
0dbca86 to
934f569
Compare
|
`public static final String SERIALIZED_NAME_DEBIT_ACCOUNT = "debitAccount"; public static final String SERIALIZED_NAME_DEBIT_ACCOUNT_TYPE = "debitAccountType"; public static final String SERIALIZED_NAME_DEBIT_ACOUNT = "debitAcount"; |
I think these are auto generated files of |
|
I did that and the typo persist (getDebitAcount). As for the parameters i previously mention they are gone. |
|
i don't see any other occurrence of acount typo. i will then proceed with the commit and push. |
934f569 to
b31f8e4
Compare
|
@adamsaghy @Aman-Mittal Please can you review my PR Thanks |
IOhacker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix Acount typo to Account in Advanced Payment Allocation Loan Repayment Schedule Test
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.