Skip to content

Conversation

@Kengne-yvana
Copy link
Contributor

@Kengne-yvana Kengne-yvana commented Jan 10, 2026

Fix Acount typo to Account in Advanced Payment Allocation Loan Repayment Schedule Test

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

Copy link
Contributor

@Aman-Mittal Aman-Mittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small Change - in comment code

@Kengne-yvana
Copy link
Contributor Author

@Aman-Mittal yes a very tiny change , I too was suprised at first.

Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you run a search for the word of acount and fix all occurrences?
I believe there is a org.apache.fineract.portfolio.tax.domain.TaxComponent#getDebitAcount which seems incorrect.

@Kengne-yvana
Copy link
Contributor Author

Yeah sure please create a ticket for that and assign that to me .
@adamsaghy

@adamsaghy
Copy link
Contributor

@Kengne-yvana I dont want to create a new ticket for this, you can fix part of this PR. Lets just rename the PR and commit message to:

FINERACT-2430: Fix typo: rename `acount` to `account`

@Kengne-yvana
Copy link
Contributor Author

@adamsaghy Ok , I understand.

@Kengne-yvana Kengne-yvana changed the title FINERACT-2430 Fix Acount typo to Account in Advanced Payment Allocation Loan Repayment Schedule Test FINERACT-2430: Fix typo: rename acount to `account Jan 12, 2026
@Kengne-yvana
Copy link
Contributor Author

@adamsaghy From my search i noticed
debitAcount and debitAccount are both parameters . and i thing the typo was intentional. should i still proceed ?

@adamsaghy
Copy link
Contributor

@adamsaghy From my search i noticed debitAcount and debitAccount are both parameters . and i thing the typo was intentional. should i still proceed ?

Please pull the latest develop branch first and reiterate the search!

@Kengne-yvana Kengne-yvana force-pushed the FINERACT-2430-fix-account-typo-v1 branch from 0dbca86 to 934f569 Compare January 12, 2026 14:22
@Kengne-yvana
Copy link
Contributor Author

`public static final String SERIALIZED_NAME_DEBIT_ACCOUNT = "debitAccount";
@SerializedName(SERIALIZED_NAME_DEBIT_ACCOUNT)
private GLAccount debitAccount;

public static final String SERIALIZED_NAME_DEBIT_ACCOUNT_TYPE = "debitAccountType";
@SerializedName(SERIALIZED_NAME_DEBIT_ACCOUNT_TYPE)
private Integer debitAccountType;

public static final String SERIALIZED_NAME_DEBIT_ACOUNT = "debitAcount";
@SerializedName(SERIALIZED_NAME_DEBIT_ACOUNT)
private GLAccount debitAcount;
`
@adamsaghy still the same.

@adamsaghy
Copy link
Contributor

`public static final String SERIALIZED_NAME_DEBIT_ACCOUNT = "debitAccount"; @SerializedName(SERIALIZED_NAME_DEBIT_ACCOUNT) private GLAccount debitAccount;

public static final String SERIALIZED_NAME_DEBIT_ACCOUNT_TYPE = "debitAccountType"; @SerializedName(SERIALIZED_NAME_DEBIT_ACCOUNT_TYPE) private Integer debitAccountType;

public static final String SERIALIZED_NAME_DEBIT_ACOUNT = "debitAcount"; @SerializedName(SERIALIZED_NAME_DEBIT_ACOUNT) private GLAccount debitAcount; ` @adamsaghy still the same.

I think these are auto generated files of fineract-client. You can run ./gradlew :clean and they should go away. Once the
org.apache.fineract.portfolio.tax.domain.TaxComponent#getDebitAcount was renamed.

@Kengne-yvana
Copy link
Contributor Author

I did that and the typo persist (getDebitAcount). As for the parameters i previously mention they are gone.
@adamsaghy
thanks

@Kengne-yvana
Copy link
Contributor Author

i don't see any other occurrence of acount typo. i will then proceed with the commit and push.
thanks for your guidance . Please let me know if there is any other minor issue you would like me to fix.

@Kengne-yvana Kengne-yvana force-pushed the FINERACT-2430-fix-account-typo-v1 branch from 934f569 to b31f8e4 Compare January 12, 2026 17:03
@Kengne-yvana
Copy link
Contributor Author

@adamsaghy @Aman-Mittal Please can you review my PR

Thanks

Copy link
Contributor

@IOhacker IOhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy adamsaghy merged commit 53ff744 into apache:develop Jan 15, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants