-
Notifications
You must be signed in to change notification settings - Fork 2.2k
FINERACT-2426: Fix ChartOfAcountsConstants typo to ChartOfAccountsConstants #5284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FINERACT-2426: Fix ChartOfAcountsConstants typo to ChartOfAccountsConstants #5284
Conversation
|
Fixing typo error of ChartOfAccountsConstants |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kengne-yvana please squash and commit, 1 commit per PR, this one has two PRs
Add the Jira ticket in the commit and in the Pull Request message "FINERACT-2426: Fix ChartOfAcountsConstants typo to ChartOfAccountsConstants"
IOhacker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly see my comments
5857c98 to
cc8376d
Compare
|
@IOhacker Done, please I'm waiting for any review |
|
@Kengne-yvana please add the Jira ticket in the Pull Request title "FINERACT-2426: Fix ChartOfAcountsConstants typo to ChartOfAccountsConstants" |
cc8376d to
3a5c2a8
Compare
|
please @IOhacker can you check now? I am done |
|
@Kengne-yvana one test failed, please run './gradlew :fineract-provider:spotlessApply' to fix these violations. Then commit and do the same squash and commit. |
3a5c2a8 to
8206f52
Compare
d813288 to
8ef361a
Compare
|
@IOhacker i ran the command you asked me to and pushed it. |
|
LGTM |
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.