Skip to content

Conversation

@Kengne-yvana
Copy link
Contributor

@Kengne-yvana Kengne-yvana commented Jan 4, 2026

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@Kengne-yvana
Copy link
Contributor Author

Kengne-yvana commented Jan 4, 2026

Fixing typo error of ChartOfAccountsConstants

Copy link
Contributor

@IOhacker IOhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kengne-yvana please squash and commit, 1 commit per PR, this one has two PRs

Add the Jira ticket in the commit and in the Pull Request message "FINERACT-2426: Fix ChartOfAcountsConstants typo to ChartOfAccountsConstants"

Copy link
Contributor

@IOhacker IOhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly see my comments

@Kengne-yvana Kengne-yvana force-pushed the FINERACT-2426--Fix-ChartOfAccountsConstants branch from 5857c98 to cc8376d Compare January 5, 2026 08:01
@Kengne-yvana
Copy link
Contributor Author

@IOhacker Done, please I'm waiting for any review
Thanks

@IOhacker
Copy link
Contributor

IOhacker commented Jan 5, 2026

@Kengne-yvana please add the Jira ticket in the Pull Request title "FINERACT-2426: Fix ChartOfAcountsConstants typo to ChartOfAccountsConstants"

@Kengne-yvana Kengne-yvana changed the title Fixing ChartOfAccountsConstants FINERACT-2426: Fix ChartOfAccountsConstants Jan 5, 2026
@Kengne-yvana Kengne-yvana changed the title FINERACT-2426: Fix ChartOfAccountsConstants https://issues.apache.org/jira/browse/FINERACT-2426 Fix ChartOfAccountsConstants Jan 5, 2026
@Kengne-yvana Kengne-yvana changed the title https://issues.apache.org/jira/browse/FINERACT-2426 Fix ChartOfAccountsConstants FINERACT-2426: Fix ChartOfAccountsConstants Jan 5, 2026
@Kengne-yvana Kengne-yvana changed the title FINERACT-2426: Fix ChartOfAccountsConstants FINERACT-2426: Fix ChartOfAcountsConstants typo to ChartOfAccountsConstants Jan 5, 2026
@Kengne-yvana Kengne-yvana changed the title FINERACT-2426: Fix ChartOfAcountsConstants typo to ChartOfAccountsConstants FINERACT-2426: Fix ChartOfAccountsConstants typo Jan 5, 2026
@Kengne-yvana Kengne-yvana changed the title FINERACT-2426: Fix ChartOfAccountsConstants typo FINERACT-2426: Fix ChartOfAcountsConstants typo to ChartOfAccountsConstants Jan 5, 2026
@Kengne-yvana Kengne-yvana force-pushed the FINERACT-2426--Fix-ChartOfAccountsConstants branch from cc8376d to 3a5c2a8 Compare January 5, 2026 08:46
@Kengne-yvana
Copy link
Contributor Author

please @IOhacker can you check now? I am done

@IOhacker
Copy link
Contributor

IOhacker commented Jan 5, 2026

@Kengne-yvana one test failed, please run './gradlew :fineract-provider:spotlessApply' to fix these violations. Then commit and do the same squash and commit.

@Kengne-yvana Kengne-yvana force-pushed the FINERACT-2426--Fix-ChartOfAccountsConstants branch from 3a5c2a8 to 8206f52 Compare January 6, 2026 07:32
@Kengne-yvana Kengne-yvana force-pushed the FINERACT-2426--Fix-ChartOfAccountsConstants branch from d813288 to 8ef361a Compare January 6, 2026 07:44
@Kengne-yvana
Copy link
Contributor Author

@IOhacker i ran the command you asked me to and pushed it.
Thanks

@Kengne-yvana Kengne-yvana requested a review from IOhacker January 6, 2026 11:35
@IOhacker
Copy link
Contributor

IOhacker commented Jan 6, 2026

LGTM

@IOhacker IOhacker merged commit 5c04216 into apache:develop Jan 6, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants