Skip to content

Conversation

@magyari-adam
Copy link
Contributor

@magyari-adam magyari-adam commented Jul 1, 2025

  • added validation for cumulative multidisburse loan applications for interest method
  • test fixes

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@magyari-adam magyari-adam force-pushed the feature/FINERACT-2181-cumulative-reschedule-fix branch from 3cb5131 to e82753b Compare July 2, 2025 07:38
@magyari-adam magyari-adam marked this pull request as ready for review July 2, 2025 08:10
@adamsaghy
Copy link
Contributor

@magyari-adam Can you please sum this PR up to me?

Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment

@magyari-adam magyari-adam force-pushed the feature/FINERACT-2181-cumulative-reschedule-fix branch 2 times, most recently from c167e38 to 5f169a3 Compare July 4, 2025 07:57
@magyari-adam magyari-adam force-pushed the feature/FINERACT-2181-cumulative-reschedule-fix branch from 5f169a3 to 9192bb2 Compare July 18, 2025 09:56
@magyari-adam magyari-adam changed the title FINERACT-2181: Cumulative loan reschedule and downpayment fix FINERACT-2181: Fix github actions not failing test runs on failed tests Jul 18, 2025
@magyari-adam magyari-adam force-pushed the feature/FINERACT-2181-cumulative-reschedule-fix branch from 9192bb2 to 27a898d Compare July 18, 2025 14:31
@adamsaghy adamsaghy force-pushed the feature/FINERACT-2181-cumulative-reschedule-fix branch from 27a898d to 85b77a7 Compare July 18, 2025 22:27
- added validation for cumulative multidisburse loan applications for interest method
- test fixes
@adamsaghy adamsaghy force-pushed the feature/FINERACT-2181-cumulative-reschedule-fix branch from 85b77a7 to f11889e Compare July 19, 2025 18:40
@adamsaghy adamsaghy merged commit de7f27f into apache:develop Jul 19, 2025
39 checks passed
@adamsaghy adamsaghy deleted the feature/FINERACT-2181-cumulative-reschedule-fix branch July 19, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants