Skip to content

Conversation

@alberto-art3ch
Copy link
Contributor

Description

For PostSavingsProductsRequest we need to enhace the swagger for the following fields:

withdrawalFeeForTransfers(false)
enforceMinRequiredBalance(false)
allowOverdraft(false)
withHoldTax(false)
isDormancyTrackingActive(false)

FINERACT-2181

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2181/swagger-enhancement-for-postsavingsproductsrequest branch from 7b400ea to 261f501 Compare July 1, 2025 02:34
@adamsaghy adamsaghy merged commit 570f44a into apache:develop Jul 1, 2025
10 checks passed
@adamsaghy adamsaghy deleted the FINERACT-2181/swagger-enhancement-for-postsavingsproductsrequest branch July 1, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants