Skip to content

Conversation

@alberto-art3ch
Copy link
Contributor

…sement

Description

There was an issue with the Loan COB job doesn't run on loan where disbursement was undone and got disbursed once again.

Now we reset last_closed_business_date, so in case it got disbursed again, COB job will pick up this loan and calculate and process necessary things

FINERACT-2181

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

Copy link
Contributor

@magyari-adam magyari-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…fter reseting Loan undo disbursement and running COB
@adamsaghy adamsaghy merged commit 1d24a8c into apache:develop Jul 1, 2025
10 checks passed
@adamsaghy adamsaghy deleted the FINERACT-2181/loan-COB-job-doesnot-run-on-the-undo-and-disbursed-loan branch July 1, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants