Skip to content

Conversation

@alberto-art3ch
Copy link
Contributor

…om / to zero

Description

To avoid the Reschedule loan with interest rate change from zero breaks repayment schedule and loan status is set to Overpaid

FINERACT-2181

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2181/loan_reschedule_interest_rate_zero branch from 925b5fe to 64b5399 Compare June 27, 2025 14:37
@ruzeynalov ruzeynalov force-pushed the FINERACT-2181/loan_reschedule_interest_rate_zero branch 2 times, most recently from 0c5c2bc to 92310fe Compare July 1, 2025 16:05
@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2181/loan_reschedule_interest_rate_zero branch from 92310fe to 3eeb5d7 Compare July 2, 2025 03:07
Copy link
Contributor

@magyari-adam magyari-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2181/loan_reschedule_interest_rate_zero branch from 3eeb5d7 to 1a44448 Compare July 2, 2025 12:20
@ruzeynalov ruzeynalov force-pushed the FINERACT-2181/loan_reschedule_interest_rate_zero branch from ce894f8 to d45a4f2 Compare July 3, 2025 10:42
@adamsaghy adamsaghy merged commit 71e7631 into apache:develop Jul 4, 2025
39 checks passed
@adamsaghy adamsaghy deleted the FINERACT-2181/loan_reschedule_interest_rate_zero branch July 4, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants