Skip to content

Conversation

@oleksii-novikov-onix
Copy link
Contributor

Description

In case it is a BatchAPI request and enclosingTransaction=true, we should collect the sub requests CommandSource entries and in case it fails at the end, we should create Audit entries for them with FAILED status. This way we can make sure there are audit entries for such requests as well.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2304/fix-auditing-of-failed-batch-request-while-enclosing-transaction-got-enabled branch from dce3a26 to 2271685 Compare June 26, 2025 14:44
@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2304/fix-auditing-of-failed-batch-request-while-enclosing-transaction-got-enabled branch from 2271685 to 55e6ba3 Compare June 30, 2025 12:12
@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2304/fix-auditing-of-failed-batch-request-while-enclosing-transaction-got-enabled branch from 55e6ba3 to 6e96ab2 Compare June 30, 2025 12:27
@galovics galovics merged commit 96eb744 into apache:develop Jul 8, 2025
10 checks passed
@galovics galovics deleted the FINERACT-2304/fix-auditing-of-failed-batch-request-while-enclosing-transaction-got-enabled branch July 8, 2025 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants