FINERACT-2198: Extend Manual Journal entry to support Asset Externalization #4785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsaghy
changed the title
adamsaghy
reviewed
Jun 19, 2025
...eract/accounting/journalentry/service/JournalEntryWritePlatformServiceJpaRepositoryImpl.java
Show resolved
Hide resolved
adamsaghy
requested changes
Jun 19, 2025
Contributor
adamsaghy
left a comment
adamsaghy
left a comment
There was a problem hiding this comment.
Please kindly see my review!
Please make sure you are adding proper testing!
alberto-art3ch
force-pushed
the
FINERACT-2198/extend-manual-journal-entry-to-support-asset-externalization
branch
from
016de77 to
2bcfb14
Compare
Contributor
Author
Testing has been added |
alberto-art3ch
force-pushed
the
FINERACT-2198/extend-manual-journal-entry-to-support-asset-externalization
branch
from
2bcfb14 to
40d49c9
Compare
oleksii-novikov-onix
approved these changes
Jun 27, 2025
adamsaghy
requested changes
Jun 30, 2025
Contributor
adamsaghy
left a comment
adamsaghy
left a comment
There was a problem hiding this comment.
https://github.com/apache/fineract/pull/4785/files#r2160481795
Please address this!
alberto-art3ch
force-pushed
the
FINERACT-2198/extend-manual-journal-entry-to-support-asset-externalization
branch
4 times, most recently
from
7a56656 to
ac0a403
Compare
Contributor
Author
Done! code updated |
alberto-art3ch
force-pushed
the
FINERACT-2198/extend-manual-journal-entry-to-support-asset-externalization
branch
from
ac0a403 to
a241201
Compare
adamsaghy
reviewed
Jul 4, 2025
| } | ||
| final Optional<ExternalAssetOwner> optExternalAssetOwner = externalAssetOwnerRepository.findByExternalId(externalId); | ||
| if (!optExternalAssetOwner.isPresent()) { | ||
| throw new ExternalAssetOwnerTransferNotFoundException(externalId); |
Contributor
There was a problem hiding this comment.
You meant "ExternalAssetOwnerNotFoundException", right?
Contributor
Author
There was a problem hiding this comment.
ExternalAssetOwnerNotFoundException
That exception is new, code updated
alberto-art3ch
force-pushed
the
FINERACT-2198/extend-manual-journal-entry-to-support-asset-externalization
branch
from
92c7860 to
2b78d7d
Compare
Contributor
|
@alberto-art3ch Please fix the failing test! |
alberto-art3ch
force-pushed
the
FINERACT-2198/extend-manual-journal-entry-to-support-asset-externalization
branch
from
2b78d7d to
0e52067
Compare
…es with asset externalization owner
adamsaghy
deleted the
FINERACT-2198/extend-manual-journal-entry-to-support-asset-externalization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.