Skip to content

FINERACT-2234: Improve LoanInterestRecalculationCOBBusinessStep business step performance #4770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamsaghy merged 1 commit into from
Jul 1, 2025
Merged

FINERACT-2234: Improve LoanInterestRecalculationCOBBusinessStep business step performance #4770

adamsaghy merged 1 commit into from
Jul 1, 2025

Conversation

@oleksii-novikov-onix
Copy link
Contributor

@oleksii-novikov-onix oleksii-novikov-onix commented Jun 13, 2025

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2234/improve-LoanInterestRecalculationCOBBusinessStep-performance branch 3 times, most recently from 1126dfa to bb98f51 Compare June 19, 2025 12:52
@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2234/improve-LoanInterestRecalculationCOBBusinessStep-performance branch 6 times, most recently from 6783e27 to fbb1fd3 Compare June 27, 2025 08:10
@oleksii-novikov-onix oleksii-novikov-onix marked this pull request as ready for review June 27, 2025 08:23
@adamsaghy
Copy link
Contributor

adamsaghy commented Jun 30, 2025

@oleksii-novikov-onix Please rebase this PR

@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2234/improve-LoanInterestRecalculationCOBBusinessStep-performance branch from fbb1fd3 to df0ada8 Compare June 30, 2025 11:46
@oleksii-novikov-onix
Copy link
Contributor Author

oleksii-novikov-onix commented Jun 30, 2025

@oleksii-novikov-onix Please rebase this PR

@adamsaghy Done

@adamsaghy adamsaghy force-pushed the FINERACT-2234/improve-LoanInterestRecalculationCOBBusinessStep-performance branch from df0ada8 to 104ad76 Compare July 1, 2025 10:24
@adamsaghy adamsaghy merged commit cb6a15c into apache:develop Jul 1, 2025
10 checks passed
@adamsaghy adamsaghy deleted the FINERACT-2234/improve-LoanInterestRecalculationCOBBusinessStep-performance branch July 1, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamsaghy adamsaghy adamsaghy left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oleksii-novikov-onix @adamsaghy