Emit metric dimension for minor compaction and other refactors#19151
Open
kfaraz wants to merge 5 commits intoapache:masterfrom
Open
Emit metric dimension for minor compaction and other refactors#19151kfaraz wants to merge 5 commits intoapache:masterfrom
kfaraz wants to merge 5 commits intoapache:masterfrom
Conversation
gianm
reviewed
Mar 13, 2026
| } | ||
|
|
||
| @JsonProperty | ||
| public String getType() |
Contributor
There was a problem hiding this comment.
This is now going to conflict with the type field added by @JsonTypeInfo. I think you can remove it.
|
|
||
| /** | ||
| * @return {@code Eligibility} denoting that the candidate interval is | ||
| * eligibile for a {@link CompactionMode#UNCOMPACTED_SEGMENTS_ONLY minor} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#19059 introduced MSQ-based minor compaction using compaction supervisors.
Once minor compaction becomes widely adopted, it would be useful to be able to easily distinguish between minor and major compaction jobs.
Changes
compactionModeandcompactionPolicyResultto compaction task context.coordinator-issued-minorfor minor compaction taskscompact/task/countmetricClientCompactionInputSpecto mirrorCompactionInputSpecClientMinorCompactionInputSpecto mirrorMinorCompactionInputSpecClientCompactionIntervalSpecEligibilityinto a separate classThis PR has: