Kubernetes executionconfig API should return effective config#19014
Open
GWphua wants to merge 5 commits intoapache:masterfrom
Open
Kubernetes executionconfig API should return effective config#19014GWphua wants to merge 5 commits intoapache:masterfrom
GWphua wants to merge 5 commits intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#18591 introduced the capability to change the max number of K8s tasks created by Overlord, and we can track the values using /druid/indexer/v1/k8s/taskrunner/executionconfig` API.
Execution Config Returns Static Config by Default
Currently, calling GET on the
/druid/indexer/v1/k8s/taskrunner/executionconfigAPI will return an empty payload if we did not submit any dynamic configs via POST on the same API. Users who depend on the API to retrieve the currently effective K8s task runner information will not see the information before the first dynamic config change is submitted.Changed the API to return the effective config, so the users will always see what is currently being used.
Release note
Users now can retrieve the Kubernetes default configuration via GET on
/druid/indexer/v1/k8s/taskrunner/executionconfigwhen there's no dynamic configs submitted.This PR has: