Open
Conversation
7a3a35d to
ce02d76
Compare
Member
|
thank you for taking care of this! |
Contributor
Author
|
Yeah I plan on trying to address these broken checks shortly. You should see updated to this PR soon, and hopefully everything passes 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18998.
Description
PR #18990 introduced the
requireUpperBoundDepsenforcer rule to catch transitive dependency version inconsistencies. However, it needed 38 exclusions to pass, since many libraries pull in conflicting transitive versions. This PR shrinks that list from 38 down to 18 by bumping dependency versions to satisfy the upper bound constraints.Bumped dependency versions
The following dependencies were bumped to the highest version required by their transitive dependency tree. All bumps are patch or minor version increments with no expected API breakages:
Added new managed dependencies
These transitive dependencies were not previously managed in the root POM, causing version conflicts. Adding them to
dependencyManagementcentralizes version control and removes the need for exclusions:kotlin-stdlib-jdk8(1.9.25) — aligns with existingkotlin-stdlibproto-google-common-protos(2.48.0) — version moved fromindexing-service/pom.xmljakarta.activation-api(1.2.2) — fixes conflict between docker-java and jettyhttpclient5(5.5.1) — version moved fromembedded-tests/pom.xmlhttpcore5(5.3.6) — required byhttpclient55.5.1Child POM cleanup
Removed hardcoded versions from child modules that are now centrally managed:
indexing-service/pom.xml:proto-google-common-protosversion removedembedded-tests/pom.xml:httpclient5version removedRemaining exclusions
The 18 remaining exclusions all require major version bumps or involve complex dependency trees that need separate, focused work:
Each remaining exclusion is documented inline with a comment explaining why it is still needed.
Release note
Upgraded multiple transitive dependency versions (Netty, Commons IO, Commons Compress, Caffeine, Bouncy Castle, and others) and reduced the number of
requireUpperBoundDepsenforcer exclusions from 38 to 18. No user-facing behavior changes.Key changed/added classes in this PR
pom.xml— version bumps, new managed dependencies, reduced enforcer exclusionsindexing-service/pom.xml— removed hardcodedproto-google-common-protosversionembedded-tests/pom.xml— removed hardcodedhttpclient5versionThis PR has: