Reduce lock contention overhead in BrokerServerView #18863
Draft
+536
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've noticed that under heavy segment add/drop load (100s of data nodes, millions of segments), Broker callbacks and query threads can contend for the same global lock in the server view. It's not significant portion of query time, but given:
switching from an Object lock to a RW lock seemed logical. From benchmarks, this appears to save on the order of XX-XXXus per query in high contention scenarios.
Release note
Key changed/added classes in this PR
MyFooOurBarTheirBazThis PR has: