DRILL-8544: HDF5 Files Ignoring Config Options

[cgivre]

DRILL-8544: HDF5 Files Ignoring Config Options

Description

There is a minor bug in the HDF5 plugin where the plugin was ignoring the showPreview config variable. This PR fixes it.

Documentation

No user facing changes except bug fixed.

Testing

Ran existing unit tests and tested manually.

[pjfanning]

Would it be possible to test what the serialization and deserialization results in as unit tests?

[cgivre]

Would it be possible to test what the serialization and deserialization results in as unit tests?

@pjfanning
There is a SerDe test for this plugin already. I'm not sure how to test the issue that I fixed, but I'd be happy to add a test.

drill/contrib/format-hdf5/src/test/java/org/apache/drill/exec/store/hdf5/TestHDF5Format.java

Lines 872 to 879 in 1b005f3

	@Test
	public void testSerDe() throws Exception {
	String sql = "SELECT COUNT(*) FROM dfs.`hdf5/dset.h5`";
	String plan = queryBuilder().sql(sql).explainJson();
	long cnt = queryBuilder().physical(plan).singletonLong();
	assertEquals("Counts should match",1L, cnt);
	}

[pjfanning]

@cgivre I was thinking more of a test that:

• create a Jackson ObjectMapper instance
• call writeValueAsString with a representative instance of HDF5FormatConfig
• check the JSON string returned includes the values that you want
• call readVale on the ObjectMapper instance to see if the value round trips ok (ie the HDF5FormatConfig instance you get returned from readValue matches the HDF5FormatConfig instance that you started with)

When you start playing with Jackson annotations, that affects what the serialization and deserialization does and unfortunately, Jackson releases can change the behaviour when trying to fix bugs.

[cgivre]

@cgivre I was thinking more of a test that:

• create a Jackson ObjectMapper instance
• call writeValueAsString with a representative instance of HDF5FormatConfig
• check the JSON string returned includes the values that you want
• call readVale on the ObjectMapper instance to see if the value round trips ok (ie the HDF5FormatConfig instance you get returned from readValue matches the HDF5FormatConfig instance that you started with)

When you start playing with Jackson annotations, that affects what the serialization and deserialization does and unfortunately, Jackson releases can change the behaviour when trying to fix bugs.

I added some new unit tests.

[cgivre]

@pjfanning Would you mind please approving (assuming you are ok with the changes)?
Thx!

[pjfanning]

lgtm