[fix](cloud) Fill schema change version holes before running#63443
Open
liaoxin01 wants to merge 1 commit into
Open
[fix](cloud) Fill schema change version holes before running#63443liaoxin01 wants to merge 1 commit into
liaoxin01 wants to merge 1 commit into
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
liaoxin01
force-pushed
the
fix/cloud-schema-change-fill-holes
branch
5 times, most recently
from
5a3915d to
78af3fb
Compare
Contributor
Author
|
run buildall |
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: During cloud schema change, empty rowsets created while calculating delete bitmap were only added to a temporary tablet. The real new tablet could become RUNNING with a local version graph hole after the alter version. Subsequent delete bitmap sync on the RUNNING tablet captures old rowset ids before filling local holes, so it can fail to find a continuous version path. This change fills version holes on the real new tablet after adding schema change output rowsets and before switching it to RUNNING, preserving the existing schema change rule that skips holes at or below alter_version. Unit tests cover both the local graph repair helper and the schema change finalization path, verifying capture_consistent_versions can traverse through the filled empty rowset.
### Release note
None
### Check List (For Author)
- Test: Unit Test
- ./run-be-ut.sh --run --filter=CloudSchemaChangeJobTest.FillVersionHolesBeforeNewTabletRunning:CloudTabletDeleteRowsetsForSchemaChangeTest.TestFillVersionHolesBeforeSchemaChangeRunning -j 8
- Behavior changed: Yes. Cloud schema change now repairs local version holes on the real new tablet before it becomes RUNNING.
- Does this need documentation: No
liaoxin01
force-pushed
the
fix/cloud-schema-change-fill-holes
branch
from
78af3fb to
db71d76
Compare
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 31200 ms |
Contributor
TPC-DS: Total hot run time: 170019 ms |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: During cloud schema change, empty rowsets created while calculating delete bitmap were only added to a temporary tablet. The real new tablet could become RUNNING with a local version graph hole after the alter version. Subsequent delete bitmap sync on the RUNNING MOW tablet captures old rowset ids before filling local holes, so it can fail to find a continuous version path.
This change fills version holes on the real new tablet after adding schema change output rowsets and before switching it to RUNNING. It preserves the existing schema change rule that skips holes at or below alter_version. A unit test covers the local graph repair and verifies capture_consistent_versions can traverse through the filled empty rowset.
Release note
None
Check List (For Author)