Skip to content

[fix](cloud) Prevent tablet KV leak after partial recycle failure#63377

Open
wyxxxcat wants to merge 1 commit into
apache:masterfrom
wyxxxcat:prevent_kv_leak
Open

[fix](cloud) Prevent tablet KV leak after partial recycle failure#63377
wyxxxcat wants to merge 1 commit into
apache:masterfrom
wyxxxcat:prevent_kv_leak

Conversation

@wyxxxcat
Copy link
Copy Markdown
Collaborator

@wyxxxcat wyxxxcat commented May 19, 2026

What problem does this PR solve?

recycle_tablets now deletes KV entries only for tablets whose object cleanup succeeded.
On partial deletion failure, it returns -1 while preserving KV consistency for failed tablets, so retry can succeed later.
Added a regression/unit test for partial recycle failure, plus a test sync point in SyncExecutor.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wyxxxcat
Copy link
Copy Markdown
Collaborator Author

/review

@wyxxxcat
Copy link
Copy Markdown
Collaborator Author

run buildall

@wyxxxcat
Copy link
Copy Markdown
Collaborator Author

/review

@wyxxxcat
Copy link
Copy Markdown
Collaborator Author

run buildall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants