branch-4.1: [fix](be) Reject super wildcard path in json keys #63300#63369
Open
github-actions[bot] wants to merge 1 commit into
Open
branch-4.1: [fix](be) Reject super wildcard path in json keys #63300#63369github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: `json_keys`/`jsonb_keys` rejected ordinary wildcard
paths but allowed super wildcard paths such as $**.a to fall through and
return NULL. The function only supports reading keys from a single
object, so super wildcard paths should fail with the same
INVALID_JSON_PATH error as other wildcard paths.
### Release note
Reject unsupported super wildcard JSON paths in json_keys/jsonb_keys
instead of returning NULL.
### Check List (For Author)
- Test: Unit Test / Regression test / Static check
- Unit Test: ./run-be-ut.sh --run
--filter=FunctionJsonbTEST.JsonbKeysRejectSuperWildcardPath
- Regression test: Added
regression-test/suites/jsonb_p0/test_jsonb_keys_invalid_path.groovy (not
run locally; no FE/BE cluster was listening on configured regression
ports)
- Static check: build-support/check-format.sh
- Static check: build-support/run-clang-tidy.sh --build-dir
be/ut_build_ASAN (failed due to pre-existing function_jsonb.cpp
complexity diagnostics and toolchain header/NOLINTEND errors)
- Behavior changed: Yes (json_keys/jsonb_keys now return
INVALID_JSON_PATH for $** paths instead of NULL)
- Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #63300