branch-4.1: [fix](fe) Fix alias function with cast outermost expr and reject illegal expressions #63254#63349
Open
github-actions[bot] wants to merge 1 commit into
Open
branch-4.1: [fix](fe) Fix alias function with cast outermost expr and reject illegal expressions #63254#63349github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…gal expressions (#63254) ### What problem does this PR solve? Problem Summary: 1. When an alias function body has a cast as the outermost expression (e.g., `cast(n as varchar(20))`), AliasUdf.translateToNereidsFunction attempted to cast the parsed expression to UnboundFunction, causing ClassCastException. Fixed by changing the unboundFunction field type from UnboundFunction to Expression so any expression can be stored. 2. Alias functions whose body contains aggregate functions, window expressions, subqueries, or other non-scalar expressions could be created successfully, which is incorrect. Added a containsType check in translateToLegacyExpr that throws AnalysisException("Alias function only supports scalar functions.") before attempting the legacy translation. ### Release note Fix alias function creation failure when the outermost expression is a cast, and reject alias functions containing aggregate/window/subquery expressions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #63254