[fix](ldap) Replace custom LDAP filter escaping with LdapEncoder.filterEncode to prevent injection vulnerabilities and add related documentation. (#61662)#61777
Merged
yiguolei merged 1 commit intoapache:branch-4.0from Mar 27, 2026
Conversation
…terEncode` to prevent injection vulnerabilities and add related documentation. (apache#61662) When constructing LDAP search filters, the {login} placeholder in ldap_user_filter and ldap_group_filter is replaced with the raw username. If the username contains LDAP filter special characters (*, (, ), \, NUL), these characters are interpreted as part of the filter syntax rather than literal values, which may cause unexpected query behavior or incorrect search results. This PR ensures all {login} substitutions are properly escaped per RFC 4515 using Spring LDAP's built-in LdapEncoder.filterEncode(), covering both the fe-core main authentication path and the fe-authentication plugin path.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
yiguolei
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pick from #61662