Skip to content

Implement eager aggregation#22281

Draft
nathanb9 wants to merge 2 commits into
apache:mainfrom
nathanb9:implement-eager-aggregation
Draft

Implement eager aggregation#22281
nathanb9 wants to merge 2 commits into
apache:mainfrom
nathanb9:implement-eager-aggregation

Conversation

@nathanb9
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added optimizer Optimizer rules core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) common Related to common crate labels May 16, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 16, 2026

Thank you for opening this pull request!

Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).

Details
     Cloning apache/main
    Building datafusion v53.1.0 (current)
       Built [  99.965s] (current)
     Parsing datafusion v53.1.0 (current)
      Parsed [   0.037s] (current)
    Building datafusion v53.1.0 (baseline)
       Built [  96.652s] (baseline)
     Parsing datafusion v53.1.0 (baseline)
      Parsed [   0.037s] (baseline)
    Checking datafusion v53.1.0 -> v53.1.0 (no change; assume patch)
     Checked [   0.901s] 222 checks: 222 pass, 30 skip
     Summary no semver update required
    Finished [ 199.581s] datafusion
    Building datafusion-common v53.1.0 (current)
       Built [  31.667s] (current)
     Parsing datafusion-common v53.1.0 (current)
      Parsed [   0.061s] (current)
    Building datafusion-common v53.1.0 (baseline)
       Built [  31.879s] (baseline)
     Parsing datafusion-common v53.1.0 (baseline)
      Parsed [   0.063s] (baseline)
    Checking datafusion-common v53.1.0 -> v53.1.0 (no change; assume patch)
     Checked [   0.899s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip

--- failure constructible_struct_adds_field: externally-constructible struct adds field ---

Description:
A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field.
        ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_field.ron

Failed in:
  field OptimizerOptions.eager_aggregation in /home/runner/work/datafusion/datafusion/datafusion/common/src/config.rs:1075

     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  66.037s] datafusion-common
    Building datafusion-physical-optimizer v53.1.0 (current)
       Built [  35.731s] (current)
     Parsing datafusion-physical-optimizer v53.1.0 (current)
      Parsed [   0.024s] (current)
    Building datafusion-physical-optimizer v53.1.0 (baseline)
       Built [  37.191s] (baseline)
     Parsing datafusion-physical-optimizer v53.1.0 (baseline)
      Parsed [   0.025s] (baseline)
    Checking datafusion-physical-optimizer v53.1.0 -> v53.1.0 (no change; assume patch)
     Checked [   0.145s] 222 checks: 222 pass, 30 skip
     Summary no semver update required
    Finished [  74.334s] datafusion-physical-optimizer
    Building datafusion-sqllogictest v53.1.0 (current)
       Built [ 166.358s] (current)
     Parsing datafusion-sqllogictest v53.1.0 (current)
      Parsed [   0.023s] (current)
    Building datafusion-sqllogictest v53.1.0 (baseline)
       Built [ 166.467s] (baseline)
     Parsing datafusion-sqllogictest v53.1.0 (baseline)
      Parsed [   0.024s] (baseline)
    Checking datafusion-sqllogictest v53.1.0 -> v53.1.0 (no change; assume patch)
     Checked [   0.107s] 222 checks: 222 pass, 30 skip
     Summary no semver update required
    Finished [ 336.959s] datafusion-sqllogictest

@github-actions github-actions Bot added the auto detected api change Auto detected API change label May 16, 2026
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto detected api change Auto detected API change common Related to common crate core Core DataFusion crate documentation Improvements or additions to documentation optimizer Optimizer rules sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant