fixing array length for empty array#22279
Open
raushanprabhakar1 wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
sqllogictest
Contributor
Author
|
Hi @Dandandan , requesting you to review. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
array_lengthof an empty array dimension should be NULL #22264.Rationale for this change
PostgreSQL returns NULL for
array_lengthon an empty dimension (e.g.array_length(array[]::int[], 1)). DataFusion returned 0. This aligns semantics with PostgreSQL as requested in the issue.What changes are included in this PR?
array_length/list_length: return SQL NULL when the evaluated dimension slice is empty, instead of0.array/array_length.sltexpectations for empty arrays and addarray_length(ARRAY[]::INT[], 1).Are these changes tested?
Yes.
cargo test --profile=ci --test sqllogictests -- array/array_length.Are there any user-facing changes?
Yes — observable SQL behavior: empty dimensions now yield NULL instead of
0forarray_length/list_length. Queries that depended on0may needIS NULLorCOALESCE.