-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add benchmark_runner info and query commands
#22032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8216ecf
Add benchmark_runner info and query commands
Omega359 37a1899
Merge branch 'main' into benchmark-runner-info-query
Omega359 7e2192f
Merge branch 'main' into benchmark-runner-info-query
Omega359 5fa69db
Merge branch 'main' into benchmark-runner-info-query
Omega359 0bf0f91
Merge branch 'main' into benchmark-runner-info-query
Omega359 e29d980
Merge branch 'main' into benchmark-runner-info-query
Omega359 22b7ae2
Merge branch 'main' into benchmark-runner-info-query
Omega359 73d96ab
Merge branch 'main' into benchmark-runner-info-query
Omega359 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,48 @@ | ||
| name = "tpch" | ||
| description = "TPC-H SQL benchmarks" | ||
|
|
||
| # Query patterns control how numeric QUERY_ID values map to .benchmark files | ||
| # during discovery and command resolution. Use exactly one query-id token: | ||
| # - {QUERY_ID_PADDED}: two-digit ids, such as q01.benchmark | ||
| # - {QUERY_ID}: unpadded ids, such as query-1.benchmark | ||
| # If omitted, this defaults to q{QUERY_ID_PADDED}.benchmark. | ||
| query_pattern = "q{QUERY_ID_PADDED}.benchmark" | ||
|
|
||
| # Path replacements define path-like variables used while parsing benchmark | ||
| # files. Relative paths are resolved from this suite file's directory and then | ||
| # passed to SqlBenchmark's replacement mapping, so benchmark SQL can refer to | ||
| # values such as ${DATA_DIR}. For timed runs, the runner's --path/-p option | ||
| # overrides DATA_DIR. | ||
| [path_replacements] | ||
| DATA_DIR = "../../data" | ||
|
|
||
| [[options]] | ||
| name = "format" | ||
| short = "f" | ||
| env = "TPCH_FILE_TYPE" | ||
| default = "parquet" | ||
| values = ["parquet", "csv", "mem"] | ||
| help = "Selects the TPC-H data format." | ||
|
|
||
| [[options]] | ||
| name = "scale-factor" | ||
| short = "sf" | ||
| env = "BENCH_SIZE" | ||
| default = "1" | ||
| values = ["1", "10"] | ||
| help = "Selects the TPC-H scale factor." | ||
|
|
||
| [[examples]] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As a minor aside, these commands don't work yet andrewlamb@Andrews-MacBook-Pro-3:~/Software/datafusion$ ^C
andrewlamb@Andrews-MacBook-Pro-3:~/Software/datafusion$ cargo run --bin benchmark_runner -- run tpch 15 -f csv
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.30s
Running `target/debug/benchmark_runner run tpch 15 -f csv`
External error: error: unrecognized subcommand 'run'
Usage: benchmark_runner [COMMAND]
For more information, try '--help'.I think you said they are coming in the next PR so that is good |
||
| command = "cargo run --release --bin benchmark_runner -- run tpch" | ||
| description = "Run all TPC-H queries with the default parquet SF1 configuration." | ||
|
|
||
| [[examples]] | ||
| command = "cargo run --release --bin benchmark_runner -- run tpch 15" | ||
| description = "Run TPC-H query 15 with the default parquet SF1 configuration." | ||
|
|
||
| [[examples]] | ||
| command = "cargo run --release --bin benchmark_runner -- run tpch 15 -f csv" | ||
| description = "Run TPC-H query 15 against CSV data." | ||
|
|
||
| [[examples]] | ||
| command = "cargo run --release --bin benchmark_runner -- run tpch 15 -sf 10" | ||
| description = "Run TPC-H query 15 at scale factor 10." | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are these changes needed?