fix: linearized operands in physical binaryexpr protobuf to avoid recursion limit#21031
Open
haohuaijin wants to merge 2 commits intoapache:mainfrom
Open
fix: linearized operands in physical binaryexpr protobuf to avoid recursion limit#21031haohuaijin wants to merge 2 commits intoapache:mainfrom
haohuaijin wants to merge 2 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
When a SQL query contains many filter conditions (e.g., 40+
AND/ORclauses in aWHERE), serializing the physical plan to protobuf and deserializing it fails withDecodeError: recursion limit reached. This is because prost has a default recursion limit of 100, and eachBinaryExprnesting consumes ~2 levels of protobuf recursion depth, so a chain of ~50 AND conditions exceeds the limit.What changes are included in this PR?
Applied the same linearization approach that logical expressions already use. Instead of encoding a chain of same-operator binary expressions as a deeply nested tree, we flatten it into a flat
operandslist:Before (nested, O(n) recursion depth):
After (flat, O(1) recursion depth for the chain):
Are these changes tested?
yes, add some test case
Are there any user-facing changes?