Skip to content

draft: testing transition from abi_stable to stabby #21025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
timsaucer wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

draft: testing transition from abi_stable to stabby #21025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
207 changes: 55 additions & 152 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion datafusion-examples/examples/ffi/ffi_example_table_provider/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ edition = { workspace = true }
publish = false

[dependencies]
abi_stable = "0.11.3"
arrow = { workspace = true }
datafusion = { workspace = true }
datafusion-ffi = { workspace = true }
Expand Down
8 changes: 3 additions & 5 deletions datafusion-examples/examples/ffi/ffi_example_table_provider/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,12 @@

use std::sync::Arc;

use abi_stable::{export_root_module, prefix_type::PrefixTypeTrait};
use arrow::array::RecordBatch;
use arrow::datatypes::{DataType, Field, Schema};
use datafusion::{common::record_batch, datasource::MemTable};
use datafusion_ffi::proto::logical_extension_codec::FFI_LogicalExtensionCodec;
use datafusion_ffi::table_provider::FFI_TableProvider;
use ffi_module_interface::{TableProviderModule, TableProviderModuleRef};
use ffi_module_interface::TableProviderModule;

fn create_record_batch(start_value: i32, num_values: usize) -> RecordBatch {
let end_value = start_value + num_values as i32;
Expand Down Expand Up @@ -56,11 +55,10 @@ extern "C" fn construct_simple_table_provider(
FFI_TableProvider::new_with_ffi_codec(Arc::new(table_provider), true, None, codec)
}

#[export_root_module]
/// This defines the entry point for using the module.
pub fn get_simple_memory_table() -> TableProviderModuleRef {
#[unsafe(no_mangle)]
pub extern "C" fn ffi_example_get_module() -> TableProviderModule {
TableProviderModule {
create_table: construct_simple_table_provider,
}
.leak_into_prefix()
}
1 change: 0 additions & 1 deletion datafusion-examples/examples/ffi/ffi_module_interface/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,4 @@ publish = false
workspace = true

[dependencies]
abi_stable = "0.11.3"
datafusion-ffi = { workspace = true }
Loading
Loading