Skip to content

Conversation

@pepijnve
Copy link
Contributor

@pepijnve pepijnve commented Feb 1, 2026

Which issue does this PR close?

Rationale for this change

While reviewing #19994 it became clear the optimised ExpressionOrExpression code path was not being used when the case expression has no else branch or has else null. In those situations the general evaluation strategies could end up being used.
This PR refines the ExpressionOrExpression implementation to also handle else null expressions.

What changes are included in this PR?

Use ExpressionOrExpression for expressions of the form CASE WHEN x THEN y [ELSE NULL]

Are these changes tested?

Covered by existing SLTs

Are there any user-facing changes?

No

@github-actions github-actions bot added the physical-expr Changes to the physical-expr crates label Feb 1, 2026
@Dandandan
Copy link
Contributor

run benchmark case_when

@alamb-ghbot
Copy link

🤖 ./gh_compare_branch_bench.sh compare_branch_bench.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing expr_or_expr (0d64069) to 9de192a diff
BENCH_NAME=case_when
BENCH_COMMAND=cargo bench --features=parquet --bench case_when
BENCH_FILTER=
BENCH_BRANCH_NAME=expr_or_expr
Results will be posted here when complete

@Dandandan
Copy link
Contributor

run benchmark tpcds

@alamb-ghbot
Copy link

🤖: Benchmark completed

Details

group                                                                                                                             expr_or_expr                           main
-----                                                                                                                             ------------                           ----
case_when 8192x100: CASE WHEN c1 < 0 THEN 0 WHEN c1 < 1000 THEN 1 ... WHEN c1 < n * 1000 THEN n ELSE n + 1 END                    1.00    125.6±1.58µs        ? ?/sec    1.01    126.5±3.62µs        ? ?/sec
case_when 8192x100: CASE WHEN c1 <= 500 THEN 1 ELSE 0 END                                                                         1.00     14.7±0.10µs        ? ?/sec    1.00     14.7±0.13µs        ? ?/sec
case_when 8192x100: CASE WHEN c1 <= 500 THEN c2 ELSE c3 END                                                                       1.00     17.1±0.57µs        ? ?/sec    1.00     17.0±0.31µs        ? ?/sec
case_when 8192x100: CASE WHEN c1 <= 500 THEN c2 [ELSE NULL] END                                                                   1.00      6.6±0.02µs        ? ?/sec    1.00      6.6±0.05µs        ? ?/sec
case_when 8192x100: CASE WHEN c1 == 0 THEN 0 WHEN c1 == 1 THEN 1 ... WHEN c1 == n THEN n ELSE n + 1 END                           1.00     48.3±0.60ms        ? ?/sec    1.00     48.3±0.48ms        ? ?/sec
case_when 8192x100: CASE c1 WHEN 0 THEN 0 WHEN 1 THEN 1 ... WHEN n THEN n ELSE n + 1 END                                          1.01     46.2±0.39µs        ? ?/sec    1.00     45.6±1.95µs        ? ?/sec
case_when 8192x100: CASE c1 WHEN 1 THEN c2 WHEN 2 THEN c3 END                                                                     1.00     30.1±0.47µs        ? ?/sec    1.02     30.6±0.76µs        ? ?/sec
case_when 8192x100: CASE c2 WHEN 0 THEN 0 WHEN 1000 THEN 1 ... WHEN n * 1000 THEN n ELSE n + 1 END                                1.00     38.8±0.48µs        ? ?/sec    1.00     38.9±0.92µs        ? ?/sec
case_when 8192x3: CASE WHEN c1 < 0 THEN 0 WHEN c1 < 1000 THEN 1 ... WHEN c1 < n * 1000 THEN n ELSE n + 1 END                      1.00    126.2±1.53µs        ? ?/sec    1.00    125.6±1.97µs        ? ?/sec
case_when 8192x3: CASE WHEN c1 <= 500 THEN 1 ELSE 0 END                                                                           1.00     14.7±0.21µs        ? ?/sec    1.00     14.7±0.12µs        ? ?/sec
case_when 8192x3: CASE WHEN c1 <= 500 THEN c2 ELSE c3 END                                                                         1.00     16.8±0.24µs        ? ?/sec    1.01     16.9±0.50µs        ? ?/sec
case_when 8192x3: CASE WHEN c1 <= 500 THEN c2 [ELSE NULL] END                                                                     1.00      6.6±0.02µs        ? ?/sec    1.01      6.6±0.15µs        ? ?/sec
case_when 8192x3: CASE WHEN c1 == 0 THEN 0 WHEN c1 == 1 THEN 1 ... WHEN c1 == n THEN n ELSE n + 1 END                             1.01     48.6±0.30ms        ? ?/sec    1.00     48.3±0.47ms        ? ?/sec
case_when 8192x3: CASE c1 WHEN 0 THEN 0 WHEN 1 THEN 1 ... WHEN n THEN n ELSE n + 1 END                                            1.02     46.1±1.52µs        ? ?/sec    1.00     45.3±0.52µs        ? ?/sec
case_when 8192x3: CASE c1 WHEN 1 THEN c2 WHEN 2 THEN c3 END                                                                       1.00     29.9±0.64µs        ? ?/sec    1.01     30.2±1.05µs        ? ?/sec
case_when 8192x3: CASE c2 WHEN 0 THEN 0 WHEN 1000 THEN 1 ... WHEN n * 1000 THEN n ELSE n + 1 END                                  1.01     38.8±0.95µs        ? ?/sec    1.00     38.5±0.64µs        ? ?/sec
case_when 8192x50: CASE WHEN c1 < 0 THEN 0 WHEN c1 < 1000 THEN 1 ... WHEN c1 < n * 1000 THEN n ELSE n + 1 END                     1.00    125.7±1.31µs        ? ?/sec    1.00    126.3±3.27µs        ? ?/sec
case_when 8192x50: CASE WHEN c1 <= 500 THEN 1 ELSE 0 END                                                                          1.01     14.9±0.39µs        ? ?/sec    1.00     14.7±0.05µs        ? ?/sec
case_when 8192x50: CASE WHEN c1 <= 500 THEN c2 ELSE c3 END                                                                        1.00     17.2±0.54µs        ? ?/sec    1.02     17.5±0.49µs        ? ?/sec
case_when 8192x50: CASE WHEN c1 <= 500 THEN c2 [ELSE NULL] END                                                                    1.00      6.6±0.03µs        ? ?/sec    1.01      6.6±0.21µs        ? ?/sec
case_when 8192x50: CASE WHEN c1 == 0 THEN 0 WHEN c1 == 1 THEN 1 ... WHEN c1 == n THEN n ELSE n + 1 END                            1.01     48.9±0.57ms        ? ?/sec    1.00     48.4±0.57ms        ? ?/sec
case_when 8192x50: CASE c1 WHEN 0 THEN 0 WHEN 1 THEN 1 ... WHEN n THEN n ELSE n + 1 END                                           1.02     46.1±0.38µs        ? ?/sec    1.00     45.1±0.35µs        ? ?/sec
case_when 8192x50: CASE c1 WHEN 1 THEN c2 WHEN 2 THEN c3 END                                                                      1.02     30.3±0.80µs        ? ?/sec    1.00     29.9±0.84µs        ? ?/sec
case_when 8192x50: CASE c2 WHEN 0 THEN 0 WHEN 1000 THEN 1 ... WHEN n * 1000 THEN n ELSE n + 1 END                                 1.00     38.6±0.54µs        ? ?/sec    1.00     38.5±0.60µs        ? ?/sec
divide_by_zero_protection/8192 rows, 0% zeros: DivideByZeroProtection                                                             1.00     82.3±0.63µs        ? ?/sec    1.60    131.9±0.66µs        ? ?/sec
divide_by_zero_protection/8192 rows, 0% zeros: ExpressionOrExpression                                                             1.00     84.2±0.52µs        ? ?/sec    1.59    133.7±1.41µs        ? ?/sec
divide_by_zero_protection/8192 rows, 10% zeros: DivideByZeroProtection                                                            1.00     77.5±0.50µs        ? ?/sec    1.62    125.3±2.14µs        ? ?/sec
divide_by_zero_protection/8192 rows, 10% zeros: ExpressionOrExpression                                                            1.00     79.6±0.60µs        ? ?/sec    1.59    126.9±0.81µs        ? ?/sec
divide_by_zero_protection/8192 rows, 50% zeros: DivideByZeroProtection                                                            1.00     55.4±0.58µs        ? ?/sec    1.64     90.8±0.33µs        ? ?/sec
divide_by_zero_protection/8192 rows, 50% zeros: ExpressionOrExpression                                                            1.00     56.6±0.73µs        ? ?/sec    1.63     92.6±0.74µs        ? ?/sec
divide_by_zero_protection/8192 rows, 90% zeros: DivideByZeroProtection                                                            1.00     20.3±0.31µs        ? ?/sec    2.21     44.7±1.53µs        ? ?/sec
divide_by_zero_protection/8192 rows, 90% zeros: ExpressionOrExpression                                                            1.00     20.7±0.30µs        ? ?/sec    2.17     44.9±0.49µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 10 entries, all equally true/case_when 8192 rows: in_range: 0.1, nulls: 0           1.00    117.6±2.54µs        ? ?/sec    1.11   130.7±14.76µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 10 entries, all equally true/case_when 8192 rows: in_range: 0.1, nulls: 0.1         1.00    132.7±2.20µs        ? ?/sec    1.07   141.7±11.05µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 10 entries, all equally true/case_when 8192 rows: in_range: 0.1, nulls: 0.5         1.00    136.4±2.20µs        ? ?/sec    1.04    141.9±6.14µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 10 entries, all equally true/case_when 8192 rows: in_range: 0.5, nulls: 0           1.00    117.3±1.36µs        ? ?/sec    1.09   128.3±11.24µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 10 entries, all equally true/case_when 8192 rows: in_range: 0.5, nulls: 0.1         1.00    133.1±2.94µs        ? ?/sec    1.06    141.6±9.91µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 10 entries, all equally true/case_when 8192 rows: in_range: 0.5, nulls: 0.5         1.00    136.0±0.80µs        ? ?/sec    1.05    143.1±6.46µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 10 entries, all equally true/case_when 8192 rows: in_range: 0.9, nulls: 0           1.00    118.1±5.98µs        ? ?/sec    1.08   127.3±10.96µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 10 entries, all equally true/case_when 8192 rows: in_range: 0.9, nulls: 0.1         1.00    132.5±0.46µs        ? ?/sec    1.09   144.5±11.81µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 10 entries, all equally true/case_when 8192 rows: in_range: 1, nulls: 0             1.00    117.8±3.26µs        ? ?/sec    1.09   128.2±10.92µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 10 entries, only first 2 are true/case_when 8192 rows: in_range: 0.1, nulls: 0      1.00    109.9±2.43µs        ? ?/sec    1.00    110.4±1.59µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 10 entries, only first 2 are true/case_when 8192 rows: in_range: 0.1, nulls: 0.1    1.00    120.0±0.97µs        ? ?/sec    1.00    120.6±2.23µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 10 entries, only first 2 are true/case_when 8192 rows: in_range: 0.1, nulls: 0.5    1.00    120.8±0.71µs        ? ?/sec    1.00    121.2±1.01µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 10 entries, only first 2 are true/case_when 8192 rows: in_range: 0.5, nulls: 0      1.00    110.6±1.61µs        ? ?/sec    1.00    110.6±4.85µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 10 entries, only first 2 are true/case_when 8192 rows: in_range: 0.5, nulls: 0.1    1.00    119.9±0.98µs        ? ?/sec    1.00    119.7±1.07µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 10 entries, only first 2 are true/case_when 8192 rows: in_range: 0.5, nulls: 0.5    1.00    121.1±1.56µs        ? ?/sec    1.00    120.8±0.96µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 10 entries, only first 2 are true/case_when 8192 rows: in_range: 0.9, nulls: 0      1.00    110.2±1.90µs        ? ?/sec    1.00    110.2±1.74µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 10 entries, only first 2 are true/case_when 8192 rows: in_range: 0.9, nulls: 0.1    1.00    119.9±1.33µs        ? ?/sec    1.00    119.9±0.82µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 10 entries, only first 2 are true/case_when 8192 rows: in_range: 1, nulls: 0        1.00    109.8±1.45µs        ? ?/sec    1.00    109.5±1.40µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 20 entries, all equally true/case_when 8192 rows: in_range: 0.1, nulls: 0           1.00    119.0±1.69µs        ? ?/sec    1.08    128.7±8.70µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 20 entries, all equally true/case_when 8192 rows: in_range: 0.1, nulls: 0.1         1.00    133.0±1.70µs        ? ?/sec    1.08    143.4±6.72µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 20 entries, all equally true/case_when 8192 rows: in_range: 0.1, nulls: 0.5         1.00    147.1±4.23µs        ? ?/sec    1.03    152.0±4.47µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 20 entries, all equally true/case_when 8192 rows: in_range: 0.5, nulls: 0           1.00    119.1±1.50µs        ? ?/sec    1.08    129.1±7.45µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 20 entries, all equally true/case_when 8192 rows: in_range: 0.5, nulls: 0.1         1.00    133.1±2.28µs        ? ?/sec    1.08    143.5±8.68µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 20 entries, all equally true/case_when 8192 rows: in_range: 0.5, nulls: 0.5         1.00    146.3±0.82µs        ? ?/sec    1.04    152.3±4.78µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 20 entries, all equally true/case_when 8192 rows: in_range: 0.9, nulls: 0           1.00    118.9±1.00µs        ? ?/sec    1.09    129.6±9.01µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 20 entries, all equally true/case_when 8192 rows: in_range: 0.9, nulls: 0.1         1.00    133.5±3.02µs        ? ?/sec    1.06    142.0±8.93µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 20 entries, all equally true/case_when 8192 rows: in_range: 1, nulls: 0             1.00    119.2±1.79µs        ? ?/sec    1.09    129.5±7.64µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 20 entries, only first 2 are true/case_when 8192 rows: in_range: 0.1, nulls: 0      1.00    110.0±2.04µs        ? ?/sec    1.00    110.4±2.25µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 20 entries, only first 2 are true/case_when 8192 rows: in_range: 0.1, nulls: 0.1    1.00    119.9±1.14µs        ? ?/sec    1.00    120.4±2.85µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 20 entries, only first 2 are true/case_when 8192 rows: in_range: 0.1, nulls: 0.5    1.00    121.0±1.97µs        ? ?/sec    1.00    120.9±0.83µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 20 entries, only first 2 are true/case_when 8192 rows: in_range: 0.5, nulls: 0      1.00    110.2±1.70µs        ? ?/sec    1.00    110.2±1.88µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 20 entries, only first 2 are true/case_when 8192 rows: in_range: 0.5, nulls: 0.1    1.00    119.7±0.99µs        ? ?/sec    1.00    120.1±1.87µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 20 entries, only first 2 are true/case_when 8192 rows: in_range: 0.5, nulls: 0.5    1.00    120.8±0.97µs        ? ?/sec    1.00    120.7±0.71µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 20 entries, only first 2 are true/case_when 8192 rows: in_range: 0.9, nulls: 0      1.00    109.8±1.18µs        ? ?/sec    1.00    109.9±1.79µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 20 entries, only first 2 are true/case_when 8192 rows: in_range: 0.9, nulls: 0.1    1.00    120.4±1.64µs        ? ?/sec    1.00    120.0±1.08µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 20 entries, only first 2 are true/case_when 8192 rows: in_range: 1, nulls: 0        1.00    110.3±1.95µs        ? ?/sec    1.00    110.4±2.11µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 5 entries, all equally true/case_when 8192 rows: in_range: 0.1, nulls: 0            1.00    117.8±2.86µs        ? ?/sec    1.09   128.3±13.75µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 5 entries, all equally true/case_when 8192 rows: in_range: 0.1, nulls: 0.1          1.00    130.1±0.64µs        ? ?/sec    1.06   137.9±11.55µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 5 entries, all equally true/case_when 8192 rows: in_range: 0.1, nulls: 0.5          1.00    130.4±4.27µs        ? ?/sec    1.04    135.5±8.14µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 5 entries, all equally true/case_when 8192 rows: in_range: 0.5, nulls: 0            1.00    117.6±1.07µs        ? ?/sec    1.07   126.2±11.98µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 5 entries, all equally true/case_when 8192 rows: in_range: 0.5, nulls: 0.1          1.00    130.0±0.64µs        ? ?/sec    1.09   141.2±13.00µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 5 entries, all equally true/case_when 8192 rows: in_range: 0.5, nulls: 0.5          1.00    129.7±0.67µs        ? ?/sec    1.04    134.8±8.31µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 5 entries, all equally true/case_when 8192 rows: in_range: 0.9, nulls: 0            1.00    117.6±0.35µs        ? ?/sec    1.08   127.4±13.94µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 5 entries, all equally true/case_when 8192 rows: in_range: 0.9, nulls: 0.1          1.00    130.3±0.94µs        ? ?/sec    1.07   139.1±12.65µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 5 entries, all equally true/case_when 8192 rows: in_range: 1, nulls: 0              1.00    117.9±1.64µs        ? ?/sec    1.09   128.2±13.94µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 5 entries, only first 2 are true/case_when 8192 rows: in_range: 0.1, nulls: 0       1.00    109.8±1.24µs        ? ?/sec    1.00    109.9±1.48µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 5 entries, only first 2 are true/case_when 8192 rows: in_range: 0.1, nulls: 0.1     1.00    119.9±0.74µs        ? ?/sec    1.01    120.7±3.63µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 5 entries, only first 2 are true/case_when 8192 rows: in_range: 0.1, nulls: 0.5     1.00    121.0±1.91µs        ? ?/sec    1.00    121.2±1.27µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 5 entries, only first 2 are true/case_when 8192 rows: in_range: 0.5, nulls: 0       1.00    110.2±1.88µs        ? ?/sec    1.01    110.8±1.53µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 5 entries, only first 2 are true/case_when 8192 rows: in_range: 0.5, nulls: 0.1     1.00    119.8±0.66µs        ? ?/sec    1.01    120.7±3.07µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 5 entries, only first 2 are true/case_when 8192 rows: in_range: 0.5, nulls: 0.5     1.00    121.0±2.17µs        ? ?/sec    1.00    120.9±1.44µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 5 entries, only first 2 are true/case_when 8192 rows: in_range: 0.9, nulls: 0       1.00    109.7±1.46µs        ? ?/sec    1.00    110.2±3.19µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 5 entries, only first 2 are true/case_when 8192 rows: in_range: 0.9, nulls: 0.1     1.00    119.8±1.36µs        ? ?/sec    1.00    120.0±1.17µs        ? ?/sec
lookup_table_case_when/case when i32 -> utf8, 5 entries, only first 2 are true/case_when 8192 rows: in_range: 1, nulls: 0         1.00    110.2±1.64µs        ? ?/sec    1.00    110.2±2.74µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 10 entries, all equally true/case_when 8192 rows: in_range: 0.1, nulls: 0           1.00    143.0±3.65µs        ? ?/sec    1.01    143.9±3.78µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 10 entries, all equally true/case_when 8192 rows: in_range: 0.1, nulls: 0.1         1.00    148.2±2.78µs        ? ?/sec    1.01    150.2±3.97µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 10 entries, all equally true/case_when 8192 rows: in_range: 0.1, nulls: 0.5         1.00    134.3±0.96µs        ? ?/sec    1.01    135.4±2.46µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 10 entries, all equally true/case_when 8192 rows: in_range: 0.5, nulls: 0           1.00    142.7±1.66µs        ? ?/sec    1.00    143.3±1.93µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 10 entries, all equally true/case_when 8192 rows: in_range: 0.5, nulls: 0.1         1.01    150.2±4.67µs        ? ?/sec    1.00    148.8±1.80µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 10 entries, all equally true/case_when 8192 rows: in_range: 0.5, nulls: 0.5         1.00    137.1±4.78µs        ? ?/sec    1.03    140.6±4.45µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 10 entries, all equally true/case_when 8192 rows: in_range: 0.9, nulls: 0           1.00    142.1±2.61µs        ? ?/sec    1.01    144.0±3.64µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 10 entries, all equally true/case_when 8192 rows: in_range: 0.9, nulls: 0.1         1.00    148.0±2.23µs        ? ?/sec    1.08    159.7±3.64µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 10 entries, all equally true/case_when 8192 rows: in_range: 1, nulls: 0             1.02    146.6±8.16µs        ? ?/sec    1.00    143.6±2.74µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 10 entries, only first 2 are true/case_when 8192 rows: in_range: 0.1, nulls: 0      1.00    134.1±0.83µs        ? ?/sec    1.00    134.0±0.58µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 10 entries, only first 2 are true/case_when 8192 rows: in_range: 0.1, nulls: 0.1    1.01    139.4±1.05µs        ? ?/sec    1.00    138.5±1.00µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 10 entries, only first 2 are true/case_when 8192 rows: in_range: 0.1, nulls: 0.5    1.00    130.9±0.45µs        ? ?/sec    1.00    131.0±0.43µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 10 entries, only first 2 are true/case_when 8192 rows: in_range: 0.5, nulls: 0      1.00    134.7±0.94µs        ? ?/sec    1.00    134.3±2.13µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 10 entries, only first 2 are true/case_when 8192 rows: in_range: 0.5, nulls: 0.1    1.00    138.7±1.55µs        ? ?/sec    1.01    139.7±2.91µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 10 entries, only first 2 are true/case_when 8192 rows: in_range: 0.5, nulls: 0.5    1.00    131.1±0.57µs        ? ?/sec    1.00    130.8±0.51µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 10 entries, only first 2 are true/case_when 8192 rows: in_range: 0.9, nulls: 0      1.02    137.6±4.91µs        ? ?/sec    1.00    134.4±2.63µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 10 entries, only first 2 are true/case_when 8192 rows: in_range: 0.9, nulls: 0.1    1.01    139.6±1.23µs        ? ?/sec    1.00    138.7±0.72µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 10 entries, only first 2 are true/case_when 8192 rows: in_range: 1, nulls: 0        1.00    134.3±0.91µs        ? ?/sec    1.00    134.1±0.43µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 20 entries, all equally true/case_when 8192 rows: in_range: 0.1, nulls: 0           1.00    142.4±2.11µs        ? ?/sec    1.01    143.5±3.58µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 20 entries, all equally true/case_when 8192 rows: in_range: 0.1, nulls: 0.1         1.00    145.5±2.67µs        ? ?/sec    1.01    147.4±2.84µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 20 entries, all equally true/case_when 8192 rows: in_range: 0.1, nulls: 0.5         1.00    133.4±3.36µs        ? ?/sec    1.00    133.1±1.87µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 20 entries, all equally true/case_when 8192 rows: in_range: 0.5, nulls: 0           1.00    142.7±2.02µs        ? ?/sec    1.00    142.7±2.53µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 20 entries, all equally true/case_when 8192 rows: in_range: 0.5, nulls: 0.1         1.00    145.0±2.20µs        ? ?/sec    1.01    145.8±1.90µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 20 entries, all equally true/case_when 8192 rows: in_range: 0.5, nulls: 0.5         1.02    134.0±1.58µs        ? ?/sec    1.00    131.9±1.14µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 20 entries, all equally true/case_when 8192 rows: in_range: 0.9, nulls: 0           1.00    141.9±2.64µs        ? ?/sec    1.01    142.8±3.44µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 20 entries, all equally true/case_when 8192 rows: in_range: 0.9, nulls: 0.1         1.00    146.3±3.87µs        ? ?/sec    1.00    146.6±3.51µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 20 entries, all equally true/case_when 8192 rows: in_range: 1, nulls: 0             1.00    142.0±2.63µs        ? ?/sec    1.01    143.7±3.18µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 20 entries, only first 2 are true/case_when 8192 rows: in_range: 0.1, nulls: 0      1.00    134.7±1.21µs        ? ?/sec    1.00    134.6±1.79µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 20 entries, only first 2 are true/case_when 8192 rows: in_range: 0.1, nulls: 0.1    1.00    139.0±0.91µs        ? ?/sec    1.00    138.8±1.01µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 20 entries, only first 2 are true/case_when 8192 rows: in_range: 0.1, nulls: 0.5    1.00    131.2±1.32µs        ? ?/sec    1.00    130.8±1.73µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 20 entries, only first 2 are true/case_when 8192 rows: in_range: 0.5, nulls: 0      1.00    134.1±1.36µs        ? ?/sec    1.00    134.2±2.12µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 20 entries, only first 2 are true/case_when 8192 rows: in_range: 0.5, nulls: 0.1    1.00    138.5±1.37µs        ? ?/sec    1.00    139.0±1.10µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 20 entries, only first 2 are true/case_when 8192 rows: in_range: 0.5, nulls: 0.5    1.00    131.0±1.23µs        ? ?/sec    1.00    130.9±0.98µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 20 entries, only first 2 are true/case_when 8192 rows: in_range: 0.9, nulls: 0      1.00    133.8±0.88µs        ? ?/sec    1.01    134.6±2.36µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 20 entries, only first 2 are true/case_when 8192 rows: in_range: 0.9, nulls: 0.1    1.01    139.7±1.33µs        ? ?/sec    1.00    138.2±0.78µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 20 entries, only first 2 are true/case_when 8192 rows: in_range: 1, nulls: 0        1.00    134.1±1.51µs        ? ?/sec    1.00    134.6±3.14µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 5 entries, all equally true/case_when 8192 rows: in_range: 0.1, nulls: 0            1.00    145.6±5.71µs        ? ?/sec    1.00    146.1±6.56µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 5 entries, all equally true/case_when 8192 rows: in_range: 0.1, nulls: 0.1          1.00    146.3±0.69µs        ? ?/sec    1.02    148.6±3.53µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 5 entries, all equally true/case_when 8192 rows: in_range: 0.1, nulls: 0.5          1.00    135.1±1.45µs        ? ?/sec    1.00    135.1±1.78µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 5 entries, all equally true/case_when 8192 rows: in_range: 0.5, nulls: 0            1.00    145.0±4.10µs        ? ?/sec    1.01    145.9±4.86µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 5 entries, all equally true/case_when 8192 rows: in_range: 0.5, nulls: 0.1          1.00    146.9±2.78µs        ? ?/sec    1.01    148.1±2.80µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 5 entries, all equally true/case_when 8192 rows: in_range: 0.5, nulls: 0.5          1.00    134.4±1.68µs        ? ?/sec    1.01    135.2±3.11µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 5 entries, all equally true/case_when 8192 rows: in_range: 0.9, nulls: 0            1.00    143.9±2.76µs        ? ?/sec    1.08    155.4±6.15µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 5 entries, all equally true/case_when 8192 rows: in_range: 0.9, nulls: 0.1          1.00    146.4±0.92µs        ? ?/sec    1.01    147.7±1.73µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 5 entries, all equally true/case_when 8192 rows: in_range: 1, nulls: 0              1.05    152.8±4.31µs        ? ?/sec    1.00    144.9±1.53µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 5 entries, only first 2 are true/case_when 8192 rows: in_range: 0.1, nulls: 0       1.01    137.3±3.96µs        ? ?/sec    1.00    135.9±3.59µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 5 entries, only first 2 are true/case_when 8192 rows: in_range: 0.1, nulls: 0.1     1.01    139.7±0.95µs        ? ?/sec    1.00    138.8±1.64µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 5 entries, only first 2 are true/case_when 8192 rows: in_range: 0.1, nulls: 0.5     1.00    131.3±0.91µs        ? ?/sec    1.01    132.1±2.84µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 5 entries, only first 2 are true/case_when 8192 rows: in_range: 0.5, nulls: 0       1.00    134.7±1.29µs        ? ?/sec    1.00    134.5±0.95µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 5 entries, only first 2 are true/case_when 8192 rows: in_range: 0.5, nulls: 0.1     1.00    138.7±0.85µs        ? ?/sec    1.00    138.8±0.93µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 5 entries, only first 2 are true/case_when 8192 rows: in_range: 0.5, nulls: 0.5     1.00    131.0±2.87µs        ? ?/sec    1.00    130.5±0.72µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 5 entries, only first 2 are true/case_when 8192 rows: in_range: 0.9, nulls: 0       1.00    133.7±0.74µs        ? ?/sec    1.00    134.1±0.91µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 5 entries, only first 2 are true/case_when 8192 rows: in_range: 0.9, nulls: 0.1     1.00    139.3±0.95µs        ? ?/sec    1.00    139.6±2.55µs        ? ?/sec
lookup_table_case_when/case when utf8 -> i32, 5 entries, only first 2 are true/case_when 8192 rows: in_range: 1, nulls: 0         1.06    142.9±3.97µs        ? ?/sec    1.00    134.2±1.24µs        ? ?/sec

@alamb-ghbot
Copy link

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing expr_or_expr (0d64069) to 9de192a diff using: tpcds
Results will be posted here when complete

@alamb-ghbot
Copy link

🤖: Benchmark completed

Details

Comparing HEAD and expr_or_expr
--------------------
Benchmark tpcds_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query     ┃        HEAD ┃ expr_or_expr ┃        Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1  │    75.01 ms │     75.41 ms │     no change │
│ QQuery 2  │   215.43 ms │    213.27 ms │     no change │
│ QQuery 3  │   165.72 ms │    160.10 ms │     no change │
│ QQuery 4  │  2034.46 ms │   1923.87 ms │ +1.06x faster │
│ QQuery 5  │   293.76 ms │    282.58 ms │     no change │
│ QQuery 6  │  1459.01 ms │   1440.05 ms │     no change │
│ QQuery 7  │   527.27 ms │    518.78 ms │     no change │
│ QQuery 8  │   181.33 ms │    174.91 ms │     no change │
│ QQuery 9  │   301.73 ms │    297.97 ms │     no change │
│ QQuery 10 │   184.17 ms │    179.37 ms │     no change │
│ QQuery 11 │  1378.71 ms │   1314.17 ms │     no change │
│ QQuery 12 │    73.08 ms │     72.70 ms │     no change │
│ QQuery 13 │   570.35 ms │    557.92 ms │     no change │
│ QQuery 14 │  1926.68 ms │   1916.79 ms │     no change │
│ QQuery 15 │    31.74 ms │     32.11 ms │     no change │
│ QQuery 16 │    68.64 ms │     66.48 ms │     no change │
│ QQuery 17 │   379.27 ms │    377.62 ms │     no change │
│ QQuery 18 │   207.89 ms │    200.91 ms │     no change │
│ QQuery 19 │   241.24 ms │    233.75 ms │     no change │
│ QQuery 20 │    26.20 ms │     27.34 ms │     no change │
│ QQuery 21 │    40.04 ms │     38.33 ms │     no change │
│ QQuery 22 │   725.83 ms │    737.65 ms │     no change │
│ QQuery 23 │  1796.92 ms │   1801.45 ms │     no change │
│ QQuery 24 │   706.67 ms │    694.08 ms │     no change │
│ QQuery 25 │   542.09 ms │    541.43 ms │     no change │
│ QQuery 26 │   131.79 ms │    128.58 ms │     no change │
│ QQuery 27 │   526.36 ms │    520.57 ms │     no change │
│ QQuery 28 │   309.56 ms │    306.28 ms │     no change │
│ QQuery 29 │   473.59 ms │    465.04 ms │     no change │
│ QQuery 30 │    79.11 ms │     78.31 ms │     no change │
│ QQuery 31 │   324.28 ms │    313.00 ms │     no change │
│ QQuery 32 │    87.98 ms │     86.83 ms │     no change │
│ QQuery 33 │   218.80 ms │    213.13 ms │     no change │
│ QQuery 34 │   168.44 ms │    161.29 ms │     no change │
│ QQuery 35 │   183.74 ms │    177.38 ms │     no change │
│ QQuery 36 │   292.31 ms │    294.68 ms │     no change │
│ QQuery 37 │   255.49 ms │    261.10 ms │     no change │
│ QQuery 38 │   158.72 ms │    153.93 ms │     no change │
│ QQuery 39 │   209.41 ms │    208.91 ms │     no change │
│ QQuery 40 │   183.70 ms │    174.28 ms │ +1.05x faster │
│ QQuery 41 │    32.13 ms │     31.67 ms │     no change │
│ QQuery 42 │   150.45 ms │    146.25 ms │     no change │
│ QQuery 43 │   130.94 ms │    128.79 ms │     no change │
│ QQuery 44 │    28.67 ms │     29.41 ms │     no change │
│ QQuery 45 │    92.91 ms │     90.16 ms │     no change │
│ QQuery 46 │   332.89 ms │    328.83 ms │     no change │
│ QQuery 47 │  1052.00 ms │   1037.84 ms │     no change │
│ QQuery 48 │   417.58 ms │    412.72 ms │     no change │
│ QQuery 49 │   386.59 ms │    388.29 ms │     no change │
│ QQuery 50 │   349.60 ms │    341.97 ms │     no change │
│ QQuery 51 │   309.66 ms │    301.40 ms │     no change │
│ QQuery 52 │   153.21 ms │    147.15 ms │     no change │
│ QQuery 53 │   156.56 ms │    150.13 ms │     no change │
│ QQuery 54 │   225.19 ms │    224.32 ms │     no change │
│ QQuery 55 │   151.80 ms │    149.49 ms │     no change │
│ QQuery 56 │   217.05 ms │    212.29 ms │     no change │
│ QQuery 57 │   294.97 ms │    296.54 ms │     no change │
│ QQuery 58 │   504.34 ms │    515.35 ms │     no change │
│ QQuery 59 │   296.39 ms │    293.34 ms │     no change │
│ QQuery 60 │   217.98 ms │    216.59 ms │     no change │
│ QQuery 61 │   251.83 ms │    253.23 ms │     no change │
│ QQuery 62 │  1274.87 ms │   1284.20 ms │     no change │
│ QQuery 63 │   153.01 ms │    153.12 ms │     no change │
│ QQuery 64 │  1196.79 ms │   1194.07 ms │     no change │
│ QQuery 65 │   360.24 ms │    355.16 ms │     no change │
│ QQuery 66 │   415.99 ms │    402.65 ms │     no change │
│ QQuery 67 │   538.23 ms │    551.02 ms │     no change │
│ QQuery 68 │   385.20 ms │    381.86 ms │     no change │
│ QQuery 69 │   180.86 ms │    174.40 ms │     no change │
│ QQuery 70 │   517.66 ms │    501.00 ms │     no change │
│ QQuery 71 │   194.77 ms │    188.54 ms │     no change │
│ QQuery 72 │  2154.71 ms │   2103.80 ms │     no change │
│ QQuery 73 │   160.11 ms │    157.97 ms │     no change │
│ QQuery 74 │   849.96 ms │    831.07 ms │     no change │
│ QQuery 75 │   413.59 ms │    409.81 ms │     no change │
│ QQuery 76 │   190.34 ms │    190.87 ms │     no change │
│ QQuery 77 │   294.35 ms │    294.54 ms │     no change │
│ QQuery 78 │   676.46 ms │    677.35 ms │     no change │
│ QQuery 79 │   334.65 ms │    331.63 ms │     no change │
│ QQuery 80 │   534.77 ms │    523.87 ms │     no change │
│ QQuery 81 │    54.73 ms │     53.22 ms │     no change │
│ QQuery 82 │   287.69 ms │    278.55 ms │     no change │
│ QQuery 83 │    84.02 ms │     81.91 ms │     no change │
│ QQuery 84 │    69.17 ms │     68.92 ms │     no change │
│ QQuery 85 │   228.88 ms │    232.07 ms │     no change │
│ QQuery 86 │    60.35 ms │     59.63 ms │     no change │
│ QQuery 87 │   159.21 ms │    158.19 ms │     no change │
│ QQuery 88 │   277.33 ms │    266.00 ms │     no change │
│ QQuery 89 │   170.18 ms │    170.54 ms │     no change │
│ QQuery 90 │    47.52 ms │     47.68 ms │     no change │
│ QQuery 91 │   100.25 ms │    101.33 ms │     no change │
│ QQuery 92 │    86.66 ms │     84.97 ms │     no change │
│ QQuery 93 │   283.10 ms │    285.09 ms │     no change │
│ QQuery 94 │    95.10 ms │     91.69 ms │     no change │
│ QQuery 95 │   262.82 ms │    248.53 ms │ +1.06x faster │
│ QQuery 96 │   122.59 ms │    113.89 ms │ +1.08x faster │
│ QQuery 97 │   198.34 ms │    190.31 ms │     no change │
│ QQuery 98 │   220.73 ms │    221.08 ms │     no change │
│ QQuery 99 │ 14019.33 ms │  14007.73 ms │     no change │
└───────────┴─────────────┴──────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary           ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)           │ 51163.84ms │
│ Total Time (expr_or_expr)   │ 50586.41ms │
│ Average Time (HEAD)         │   516.81ms │
│ Average Time (expr_or_expr) │   510.97ms │
│ Queries Faster              │          4 │
│ Queries Slower              │          0 │
│ Queries with No Change      │         95 │
│ Queries with Failure        │          0 │
└─────────────────────────────┴────────────┘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-expr Changes to the physical-expr crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants