chore: Register task completion listener to ensure CometExecIterator is always closed#3959
Open
wForget wants to merge 3 commits intoapache:mainfrom
Open
chore: Register task completion listener to ensure CometExecIterator is always closed#3959wForget wants to merge 3 commits intoapache:mainfrom
wForget wants to merge 3 commits intoapache:mainfrom
Conversation
wForget
commented
Apr 16, 2026
| private var closed: Boolean = false | ||
|
|
||
| // Register a task completion listener to ensure native resources are released when the task is done. | ||
| TaskContext.get().addTaskCompletionListener[Unit] { _ => |
Member
Author
There was a problem hiding this comment.
Since TaskContext.get() has already been called, the new behavior should be safe.
andygrove
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
CometExecIterator.closeis not always registered to the task completion listener, which may lead to leaks when task fails. Like:datafusion-comet/spark/src/main/scala/org/apache/spark/sql/comet/CometNativeWriteExec.scala
Line 207 in 29557ca
datafusion-comet/spark/src/main/scala/org/apache/spark/sql/comet/execution/shuffle/CometNativeShuffleWriter.scala
Line 99 in 29557ca
What changes are included in this PR?
Always register a task completion listener for
CometExecIterator.close.How are these changes tested?