fix: log Comet execution errors before Spark can obscure them#3955
Closed
andygrove wants to merge 1 commit intoapache:mainfrom
Closed
fix: log Comet execution errors before Spark can obscure them#3955andygrove wants to merge 1 commit intoapache:mainfrom
andygrove wants to merge 1 commit intoapache:mainfrom
Conversation
00d72c9 to
40bb957
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
When a
NullPointerExceptionorAssertionErroroccurs in Comet execution code, Spark'sQueryExecution.toInternalErrorcatches it and wraps it in a generic[INTERNAL_ERROR] The "collect" action failed. You hit a bug in Spark or the Spark plugins you use.message. This hides the original Comet context (which operator failed, what the root cause was), making it very difficult for users to debug or report issues.What changes are included in this PR?
Adds error logging in the
CometPlantrait using the template method pattern:CometPlannow overridesdoExecuteColumnar,doExecute, anddoExecuteBroadcastwith awithErrorLoggingwrapper that catches exceptions, logs them with Comet-specific context (operator class name and method), and re-throws the original exception.doExecuteCometColumnar,doExecuteComet, anddoExecuteCometBroadcastinstead of the Spark methods directly.How are these changes tested?
Verified manually by injecting a
NullPointerExceptioninCometNativeExec.doExecuteCometColumnarand runningCometExecSuite. Confirmed that the error is logged with the Comet operator name and original cause before Spark wraps it.