chore: Remove all remaining uses of legacy BatchReader from Comet #3468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
force-pushed
the
remove-dead-code
branch
from
d52d593 to
5f27076
Compare
andygrove
changed the title
andygrove
changed the title
BatchReader from Comet
andygrove
changed the title
BatchReader from Comet
BatchReader is annotated @IcebergApi and kept for Iceberg compatibility, but Comet's own production code no longer uses it. The prefetch feature was entirely built on BatchReader and is dead code now that the native_iceberg_compat path uses NativeBatchReader. V2 Parquet scan acceleration (CometParquetScan) is also no longer active. This commit: - Marks BatchReader as @deprecated (since 0.14.0) - Removes all prefetch internals from BatchReader (fields, methods, inner class) - Removes COMET_SCAN_PREFETCH_ENABLED and COMET_SCAN_PREFETCH_THREAD_NUM configs - Removes CometPrefetchThreadPool - Deletes CometParquetPartitionReaderFactory and CometParquetScan - Simplifies CometScanExec.prepareRDD to always use newFileScanRDD - Removes dead BatchReader code path from CometParquetFileFormat - Cleans up EliminateRedundantTransitions V2 dead code path - Removes prefetch tests, BatchReader-only tests, and BatchReader benchmark case - Cleans up CometParquetScan references in tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
andygrove
force-pushed
the
remove-dead-code
branch
from
5f27076 to
9063e61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to merge #3446 first
Rationale
BatchReaderis annotated@IcebergApiand must be kept for Iceberg compatibility, but Comet's own production code no longer uses it. The prefetch feature was entirely built onBatchReaderand is dead code now that thenative_iceberg_compatpath usesNativeBatchReader. I checked the Iceberg source and confirmed that the prefetch feature was not used there either. Comet also no longer accelerates V2 Parquet scans, soCometParquetScanandCometParquetPartitionReaderFactoryare dead code.Summary
BatchReaderas@Deprecated(since 0.14.0) — kept for Iceberg compatibility via@IcebergApiBatchReader(fields, methods,PrefetchTaskinner class)COMET_SCAN_PREFETCH_ENABLEDandCOMET_SCAN_PREFETCH_THREAD_NUMconfigsCometPrefetchThreadPoolCometParquetPartitionReaderFactoryandCometParquetScan(V2 Parquet scan dead code)CometScanExec.prepareRDDto always usenewFileScanRDDEliminateRedundantTransitionsV2 dead code pathBatchReaderbenchmark caseCometParquetScanreferences in tests🤖 Generated with Claude Code